Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291061: Improve thread safety of FileTime.toString and toInstant #9608

Closed

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Jul 22, 2022

We need to read fields instant/valueAsString once, as to dodge/resolve the data race on reading lazily-initialized fields.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291061: Improve thread safety of FileTime.toString and toInstant

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9608/head:pull/9608
$ git checkout pull/9608

Update a local copy of the PR:
$ git checkout pull/9608
$ git pull https://git.openjdk.org/jdk pull/9608/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9608

View PR using the GUI difftool:
$ git pr show -t 9608

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9608.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2022

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 22, 2022

@turbanoff The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jul 22, 2022
@turbanoff turbanoff changed the title [PATCH] Improve thread safety of FileTime.toString and toInstant 8291061: Improve thread safety of FileTime.toString and toInstant Jul 26, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 26, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 1, 2022

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291061: Improve thread safety of FileTime.toString and toInstant

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 77 new commits pushed to the master branch:

  • 257c71c: 8290062: Remove nmethodLocker for nmethods on-stack
  • d9cb410: 8290466: Default to --with-source-date=current to avoid unmodified Hotspot recompilation
  • acbe093: 8291559: x86: compiler/vectorization/TestReverseBitsVector.java fails
  • 32d410a: 8290868: NMT: MallocSiteTable statistics improvements
  • 3579024: 8288904: Incorrect memory ordering in UL
  • 470c0eb: 8290740: Catalog not used when the handler is null
  • dd9bd31: 8289688: jfr command hangs when it processes invalid file
  • 8179a19: 8290243: move seeTagToContent from HtmlDocletWriter to TagletWriterImpl
  • 15943e4: 8282666: nsk/jvmti/PopFrame/popframe004 failed with: TEST FAILED: 30 JVMTI events were generated by the function PopFrame()
  • 0bcf176: 6227536: KeyGenerator.init() methods do not throw IllegalArgumentException for keysize == 0
  • ... and 67 more: https://git.openjdk.org/jdk/compare/e9f97b2e8cf301ba6b69101e5efc5c71d26bc87b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 1, 2022
@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 5, 2022

Going to push as commit 6e7cd76.
Since your change was applied there have been 136 commits pushed to the master branch:

  • 477f471: Merge
  • 4b3dfe1: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs
  • 6b2184e: 8290248: Implement MaxINode::Ideal transformation
  • 27c8826: 8291840: Avoid JavaCalls for setting up _java_system_loader and _java_platform_loader
  • 6e6c64c: 8291941: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all
  • 617a196: 8290812: Add a test for ResourceHashtable
  • 1edc245: 8291899: Zero VM is broken on MacOS after JDK-8290840 due to os::setup_fpu() is missing
  • 6ad6b1c: 8272998: ImageIO.read() throws incorrect exception type
  • 90257f9: 8169187: [macosx] Aqua: java/awt/image/multiresolution/MultiresolutionIconTest.java
  • c48cd88: 8291926: ProblemList multiple tests in -Xcomp mode due to JDK-8291649
  • ... and 126 more: https://git.openjdk.org/jdk/compare/e9f97b2e8cf301ba6b69101e5efc5c71d26bc87b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 5, 2022
@openjdk openjdk bot closed this Aug 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 5, 2022
@openjdk
Copy link

openjdk bot commented Aug 5, 2022

@turbanoff Pushed as commit 6e7cd76.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the improve_thread_safety_FileTime branch October 27, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
3 participants