JDK-8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false"

[MBaesken]

In seldom cases the TestJitRestart.java JFR test failed because no Jitrestart event was seen in the test.
Dean Long suggested to change the test a bit "How about changing the test to look at CodeCacheFull, compilation, and JitRestart events. It can test that no compilation events happen after CodeCacheFull unless a JitRestart comes first. So it would be testing the order of events and not absolute counts."

So I adjusted the test (still succeeds after a JitRestart is seen, but in case it is not seen only fails in case of Compilation events after CodeCacheFull).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false"

Reviewers

• Erik Gahlin (@egahlin - Reviewer)
• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9612/head:pull/9612
$ git checkout pull/9612

Update a local copy of the PR:
$ git checkout pull/9612
$ git pull https://git.openjdk.org/jdk pull/9612/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9612

View PR using the GUI difftool:
$ git pr show -t 9612

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9612.diff

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8fa080cf)
• 00: Full (9d9c77bb)

[egahlin]

There is no guarantee that events will arrive in the recording file in the same order they were committed. If the test depends on there order(?), the events should be sorted, i.e. events.sort(Comparator.comparing(RecordedEvent::getEndTime)).

[MBaesken]

There is no guarantee that events will arrive in the recording file in the same order they were committed. If the test depends on there order(?), the events should be sorted, i.e. events.sort(Comparator.comparing(RecordedEvent::getEndTime)).

Yes the order is important. However sorting using getEndTime leads to alot of errors, 50% of test runs fail this way (makes things worse) because we seem to have compilation events with end time later than the jdk.CodeCacheFull event.
However sorting using getStartTime seems to work well.

[egahlin]

I don't know enough about the compiler events and their order, but looks reasonable.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false"

Reviewed-by: egahlin, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• 97fc8de: 8291106: ZPlatformGranuleSizeShift is redundant
• dd69a68: 8291000: C2: Purge LoadPLocked and Store*Conditional nodes
• 07f0612: 8290532: Adjust PKCS11Exception and handle more PKCS11 error codes
• 93f96d8: 8290399: [macos] Aqua LAF does not fire an action event if combo box menu is displayed
• 5d82d67: 8290034: Auto vectorize reverse bit operations.
• 348a052: 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options
• bc6a3c7: 8290739: Simplify storage of dump-time class information
• 16a1275: 8290943: Fix several IR test issues on SVE after JDK-8289801
• c1a3347: 8291358: Fix the "overridding" typo
• 37b08c7: 8237913: G1CollectedHeap::heap_region_containing shouldn't be a template
• ... and 44 more: https://git.openjdk.org/jdk/compare/e9f97b2e8cf301ba6b69101e5efc5c71d26bc87b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealLucy]

Changes look good to me.

[MBaesken]

Hi Erik and Lutz, thanks for the reviews !

[MBaesken]

/integrate

[openjdk]

Going to push as commit 5d1ad39.
Since your change was applied there have been 54 commits pushed to the master branch:

• 97fc8de: 8291106: ZPlatformGranuleSizeShift is redundant
• dd69a68: 8291000: C2: Purge LoadPLocked and Store*Conditional nodes
• 07f0612: 8290532: Adjust PKCS11Exception and handle more PKCS11 error codes
• 93f96d8: 8290399: [macos] Aqua LAF does not fire an action event if combo box menu is displayed
• 5d82d67: 8290034: Auto vectorize reverse bit operations.
• 348a052: 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options
• bc6a3c7: 8290739: Simplify storage of dump-time class information
• 16a1275: 8290943: Fix several IR test issues on SVE after JDK-8289801
• c1a3347: 8291358: Fix the "overridding" typo
• 37b08c7: 8237913: G1CollectedHeap::heap_region_containing shouldn't be a template
• ... and 44 more: https://git.openjdk.org/jdk/compare/e9f97b2e8cf301ba6b69101e5efc5c71d26bc87b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 5d1ad39.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.