Skip to content

8290459: Remove unused GCCause enums #9614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

xmas92
Copy link
Member

@xmas92 xmas92 commented Jul 22, 2022


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9614/head:pull/9614
$ git checkout pull/9614

Update a local copy of the PR:
$ git checkout pull/9614
$ git pull https://git.openjdk.org/jdk pull/9614/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9614

View PR using the GUI difftool:
$ git pr show -t 9614

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9614.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jul 22, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2022

Hi @xmas92, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user xmas92" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jul 22, 2022

⚠️ @xmas92 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk
Copy link

openjdk bot commented Jul 22, 2022

@xmas92 The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 22, 2022
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Jul 25, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 25, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 25, 2022

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290459: Remove unused GCCause enums

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • d0c365a: 8170794: [macosx] Error when using setDesktopManager on a JDesktopPane on MacOS X with Look and Feel Aqua
  • 80dc6ce: 8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures."
  • 228e8e9: 8290700: Optimize AArch64 nmethod entry barriers
  • 852e71d: 8290870: NMT: Increase MallocSiteTable size and allocate it only when needed
  • 0599a05: 8290900: Build failure with Clang 14+ due to function warning attribute
  • 987656d: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java
  • 2660a92: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload
  • ef8486a: 8286270: [java.desktop] Replace color search in XColors with a switch statement
  • 62f2263: 8290861: Remove unused field URLJarFile.BUF_SIZE
  • b28f9da: 8290688: Optimize x86_64 nmethod entry barriers
  • ... and 3 more: https://git.openjdk.org/jdk/compare/e9f97b2e8cf301ba6b69101e5efc5c71d26bc87b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 25, 2022
@xmas92
Copy link
Member Author

xmas92 commented Jul 25, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 25, 2022
@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@xmas92
Your change (at version 258ec69) is now ready to be sponsored by a Committer.

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tschatzl
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 25, 2022

Going to push as commit 350808a.
Since your change was applied there have been 13 commits pushed to the master branch:

  • d0c365a: 8170794: [macosx] Error when using setDesktopManager on a JDesktopPane on MacOS X with Look and Feel Aqua
  • 80dc6ce: 8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures."
  • 228e8e9: 8290700: Optimize AArch64 nmethod entry barriers
  • 852e71d: 8290870: NMT: Increase MallocSiteTable size and allocate it only when needed
  • 0599a05: 8290900: Build failure with Clang 14+ due to function warning attribute
  • 987656d: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java
  • 2660a92: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload
  • ef8486a: 8286270: [java.desktop] Replace color search in XColors with a switch statement
  • 62f2263: 8290861: Remove unused field URLJarFile.BUF_SIZE
  • b28f9da: 8290688: Optimize x86_64 nmethod entry barriers
  • ... and 3 more: https://git.openjdk.org/jdk/compare/e9f97b2e8cf301ba6b69101e5efc5c71d26bc87b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2022
@openjdk openjdk bot closed this Jul 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 25, 2022
@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@tschatzl @xmas92 Pushed as commit 350808a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants