Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290959: Consistently use "grey" instead of "gray" in GC code #9625

Closed
wants to merge 1 commit into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Jul 25, 2022

Please review this trivial spelling change in some comments to make them
consistent with the spelling in identifier names.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290959: Consistently use "grey" instead of "gray" in GC code

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9625/head:pull/9625
$ git checkout pull/9625

Update a local copy of the PR:
$ git checkout pull/9625
$ git pull https://git.openjdk.org/jdk pull/9625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9625

View PR using the GUI difftool:
$ git pr show -t 9625

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9625.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2022

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 25, 2022
@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 25, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 25, 2022

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290959: Consistently use "grey" instead of "gray" in GC code

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 128 new commits pushed to the master branch:

  • 350808a: 8290459: Remove unused GCCause enums
  • d0c365a: 8170794: [macosx] Error when using setDesktopManager on a JDesktopPane on MacOS X with Look and Feel Aqua
  • 80dc6ce: 8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures."
  • 228e8e9: 8290700: Optimize AArch64 nmethod entry barriers
  • 852e71d: 8290870: NMT: Increase MallocSiteTable size and allocate it only when needed
  • 0599a05: 8290900: Build failure with Clang 14+ due to function warning attribute
  • 987656d: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java
  • 2660a92: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload
  • ef8486a: 8286270: [java.desktop] Replace color search in XColors with a switch statement
  • 62f2263: 8290861: Remove unused field URLJarFile.BUF_SIZE
  • ... and 118 more: https://git.openjdk.org/jdk/compare/c7c20661eee727ed8354b19723c359ae7c2d4bd8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 25, 2022
@kimbarrett
Copy link
Author

Thanks for reviewing @tschatzl .

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 25, 2022

Going to push as commit b17269a.
Since your change was applied there have been 128 commits pushed to the master branch:

  • 350808a: 8290459: Remove unused GCCause enums
  • d0c365a: 8170794: [macosx] Error when using setDesktopManager on a JDesktopPane on MacOS X with Look and Feel Aqua
  • 80dc6ce: 8290730: compiler/vectorization/TestAutoVecIntMinMax.java failed with "IRViolationException: There were one or multiple IR rule failures."
  • 228e8e9: 8290700: Optimize AArch64 nmethod entry barriers
  • 852e71d: 8290870: NMT: Increase MallocSiteTable size and allocate it only when needed
  • 0599a05: 8290900: Build failure with Clang 14+ due to function warning attribute
  • 987656d: 8289471: Issue in Initialization of keys in ErrorMsg.java and XPATHErrorResources.java
  • 2660a92: 8290893: ProblemList java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnload
  • ef8486a: 8286270: [java.desktop] Replace color search in XColors with a switch statement
  • 62f2263: 8290861: Remove unused field URLJarFile.BUF_SIZE
  • ... and 118 more: https://git.openjdk.org/jdk/compare/c7c20661eee727ed8354b19723c359ae7c2d4bd8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2022
@openjdk openjdk bot closed this Jul 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2022
@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@kimbarrett Pushed as commit b17269a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the use-grey branch July 25, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
2 participants