8290966: G1: Record number of PLAB filled and number of direct allocations

[tschatzl]

Hi all,

for evaluation in JDK-8288966 I added statistics output that show the amount of PLAB fills and direct allocations; I think this is useful for similar evaluations in the future, so I kept and split it out from that change. Adds these values to the existing JFR event too.

Testing: PLAB related tests, gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290966: G1: Record number of PLAB filled and number of direct allocations

Reviewers

• Sangheon Kim (@sangheon - Reviewer) ⚠️ Review applies to 7b242dd1
• Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to 7b242dd1

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9626/head:pull/9626
$ git checkout pull/9626

Update a local copy of the PR:
$ git checkout pull/9626
$ git pull https://git.openjdk.org/jdk pull/9626/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9626

View PR using the GUI difftool:
$ git pr show -t 9626

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9626.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (6194eea8)
• 00: Full (7b242dd1)

[sangheon]

Lgtm.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290966: G1: Record number of PLAB filled and number of direct allocations

Reviewed-by: sangheki, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• 86ef7b2: 8289046: Undefined Behaviour in x86 class Assembler
• d61c0c7: 8290497: some tests in com/sun/jdi fail on localized Windows platform
• 7ff1969: 8290067: Show stack dimensions in UL logging when attaching threads
• 257c71c: 8290062: Remove nmethodLocker for nmethods on-stack
• d9cb410: 8290466: Default to --with-source-date=current to avoid unmodified Hotspot recompilation
• acbe093: 8291559: x86: compiler/vectorization/TestReverseBitsVector.java fails
• 32d410a: 8290868: NMT: MallocSiteTable statistics improvements
• 3579024: 8288904: Incorrect memory ordering in UL
• 470c0eb: 8290740: Catalog not used when the handler is null
• dd9bd31: 8289688: jfr command hangs when it processes invalid file
• ... and 54 more: https://git.openjdk.org/jdk/compare/1e270ea4f5e8f9539e85430b9be5cf21a89b4d8f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kimbarrett]

Looks good. Just a couple whitespace comments.

[kimbarrett]

Maybe another line break in this line, to keep it's length a bit more reasonable?

[tschatzl]

Thanks @kimbarrett @sangheon for your reviews
/integrate

[openjdk]

Going to push as commit 30205bb.
Since your change was applied there have been 64 commits pushed to the master branch:

• 86ef7b2: 8289046: Undefined Behaviour in x86 class Assembler
• d61c0c7: 8290497: some tests in com/sun/jdi fail on localized Windows platform
• 7ff1969: 8290067: Show stack dimensions in UL logging when attaching threads
• 257c71c: 8290062: Remove nmethodLocker for nmethods on-stack
• d9cb410: 8290466: Default to --with-source-date=current to avoid unmodified Hotspot recompilation
• acbe093: 8291559: x86: compiler/vectorization/TestReverseBitsVector.java fails
• 32d410a: 8290868: NMT: MallocSiteTable statistics improvements
• 3579024: 8288904: Incorrect memory ordering in UL
• 470c0eb: 8290740: Catalog not used when the handler is null
• dd9bd31: 8289688: jfr command hangs when it processes invalid file
• ... and 54 more: https://git.openjdk.org/jdk/compare/1e270ea4f5e8f9539e85430b9be5cf21a89b4d8f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 30205bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.