-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1 #9628
Conversation
… intermittently with exit code 1
👋 Welcome back rsunderbabu! A progress list of the required criteria for merging this PR into |
@rsunderbabu The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
log.info("Iteration: " + stresser.getIteration()); | ||
GarbageUtils.eatMemory(stresser, garbageProducer, 0); | ||
garbageProducer = null; | ||
WhiteBox.getWhiteBox().fullGC(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to create some classes to unload them. Are they created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that part. I will correct it.
… intermittently with exit code 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please verify that it works with ZGC, ParallelGC, SerialGC.
@rsunderbabu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 138 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@lmesnik I have tested with all the GC options. |
/integrate |
@rsunderbabu |
/sponsor |
Going to push as commit 7db5abd.
Your commit was automatically rebased without conflicts. |
@lmesnik @rsunderbabu Pushed as commit 7db5abd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
LoadUnloadGC2 tests the Class unloading during GC. In order to trigger the GC, lots of memory is created at a short interval. Instead of GC getting triggered, the test quickly gets into OOME.
Using WhiteBox.fullGC is a cleaner and deterministic way to trigger GC.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9628/head:pull/9628
$ git checkout pull/9628
Update a local copy of the PR:
$ git checkout pull/9628
$ git pull https://git.openjdk.org/jdk pull/9628/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9628
View PR using the GUI difftool:
$ git pr show -t 9628
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9628.diff