Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1 #9628

Closed
wants to merge 2 commits into from

Conversation

rsunderbabu
Copy link
Member

@rsunderbabu rsunderbabu commented Jul 25, 2022

LoadUnloadGC2 tests the Class unloading during GC. In order to trigger the GC, lots of memory is created at a short interval. Instead of GC getting triggered, the test quickly gets into OOME.
Using WhiteBox.fullGC is a cleaner and deterministic way to trigger GC.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9628/head:pull/9628
$ git checkout pull/9628

Update a local copy of the PR:
$ git checkout pull/9628
$ git pull https://git.openjdk.org/jdk pull/9628/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9628

View PR using the GUI difftool:
$ git pr show -t 9628

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9628.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2022

👋 Welcome back rsunderbabu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 25, 2022
@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@rsunderbabu The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 25, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 25, 2022

Webrevs

log.info("Iteration: " + stresser.getIteration());
GarbageUtils.eatMemory(stresser, garbageProducer, 0);
garbageProducer = null;
WhiteBox.getWhiteBox().fullGC();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to create some classes to unload them. Are they created?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that part. I will correct it.

Copy link
Member

@lmesnik lmesnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please verify that it works with ZGC, ParallelGC, SerialGC.

@openjdk
Copy link

openjdk bot commented Jul 27, 2022

@rsunderbabu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1

Reviewed-by: lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 138 new commits pushed to the master branch:

  • 8e2c006: 8291957: Redundant import statements in sun.security.ec
  • ae52053: 8291954: Use Optional.isEmpty instead of !Optional.isPresent in java.base
  • 87cda21: Merge
  • 5963300: 8290562: ThreadMXBean.getThread{Cpu,User}Time fails with -XX:-VMContinuations
  • 0657acf: 8289249: Add methods to Elements for record constructors
  • b66a0d1: 8291992: [REDO2] ProblemList multiple tests in -Xcomp mode due to JDK-8291649
  • 9bff3b7: 8291990: [REDO] ProblemList multiple tests in -Xcomp mode due to JDK-8291649
  • f9bb367: 8291653: G1 refinement incorrectly expects always-valid HeapRegion out of the Hot Card Cache
  • b17a745: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value
  • 0da4314: 8288732: Reduce runtime of java.util.concurrent microbenchmarks
  • ... and 128 more: https://git.openjdk.org/jdk/compare/350808a5a3cbaa097c3360bfca9af6d90f1b223b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 27, 2022
@rsunderbabu
Copy link
Member Author

Looks good, please verify that it works with ZGC, ParallelGC, SerialGC.

@lmesnik I have tested with all the GC options.

@rsunderbabu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 8, 2022
@openjdk
Copy link

openjdk bot commented Aug 8, 2022

@rsunderbabu
Your change (at version 1844729) is now ready to be sponsored by a Committer.

@lmesnik
Copy link
Member

lmesnik commented Aug 8, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 8, 2022

Going to push as commit 7db5abd.
Since your change was applied there have been 149 commits pushed to the master branch:

  • 124fc4a: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version
  • 4591937: 8290357: Drop HeapRegion::marked_bytes()
  • 7676be8: 8291037: Move PLAB resizing mechanism to G1EvacStats
  • 861cc67: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)
  • 8d88be2: 8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)
  • 8a804f6: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk
  • 5a539e8: 8291893: riscv: remove fence.i used in user space
  • b2f0cbd: 8064787: [macosx] In Nimbus LaF, Ctrl+Alt mnemonic doesn't work
  • 891df21: 8259687: JTabbedPane.setComponentAt doesn't hide previously visible tab component
  • d4fb91b: 8291956: Simplify the loop condition in sun.net.httpserver.Request constructor
  • ... and 139 more: https://git.openjdk.org/jdk/compare/350808a5a3cbaa097c3360bfca9af6d90f1b223b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 8, 2022
@openjdk openjdk bot closed this Aug 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 8, 2022
@openjdk
Copy link

openjdk bot commented Aug 8, 2022

@lmesnik @rsunderbabu Pushed as commit 7db5abd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rsunderbabu rsunderbabu deleted the 8282642 branch October 16, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants