Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290969: DumpClassListCLDClosure incorrectly uses ResizeableResourceHashtable #9632

Closed
wants to merge 1 commit into from

Conversation

eastig
Copy link
Member

@eastig eastig commented Jul 25, 2022

ResizeableResourceHashtable is an open hashing table which can be resized to improve search performance. It provides maybe_grow(load_factor) function for this purpose. To use this functionality an instance of ResizeableResourceHashtable must be correctly created and used:

  • The non-zero maximum table size must be specified in the constructor.
  • The default or a reasonable load factor must be used in maybe_grow(load_factor).

DumpClassListCLDClosure does not meet these requirements:

  • The maximum table size is not provided.
  • The call of maybe_grow(61333) is used. The call will work when number_of_entries > 61333*1987=121,868,671. This does not look reasonable.

This PR fixes DumpClassListCLDClosure to meet the requirements.
Tested with release/fastdebug builds:

  • gtest: Passed.
  • tier1: Passed.
  • test/hotspot/jtreg/runtime/cds: Passed.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290969: DumpClassListCLDClosure incorrectly uses ResizeableResourceHashtable

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9632/head:pull/9632
$ git checkout pull/9632

Update a local copy of the PR:
$ git checkout pull/9632
$ git pull https://git.openjdk.org/jdk pull/9632/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9632

View PR using the GUI difftool:
$ git pr show -t 9632

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9632.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2022

👋 Welcome back eastig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 25, 2022
@eastig
Copy link
Member Author

eastig commented Jul 25, 2022

Hi @iklam, @yminqi, @calvinccheung,
Could you please review the fix?

@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@eastig The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 25, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 25, 2022

Webrevs

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. The changes look good to me.

@openjdk
Copy link

openjdk bot commented Jul 25, 2022

@eastig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290969: DumpClassListCLDClosure incorrectly uses ResizeableResourceHashtable

Reviewed-by: iklam, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • a6faf5d: 8290485: [vector] REVERSE_BYTES for byte type should not emit any instructions
  • 0ca5cb1: 8290834: Improve potentially confusing documentation on collection of profiling information
  • 7c3cfd1: 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iklam, @calvinccheung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 25, 2022
Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing this.

@eastig
Copy link
Member Author

eastig commented Jul 26, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@eastig
Your change (at version bcff27c) is now ready to be sponsored by a Committer.

@simonis
Copy link
Member

simonis commented Jul 26, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 26, 2022

Going to push as commit 330adc0.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 28bbdc5: 8290972: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java
  • a6faf5d: 8290485: [vector] REVERSE_BYTES for byte type should not emit any instructions
  • 0ca5cb1: 8290834: Improve potentially confusing documentation on collection of profiling information
  • 7c3cfd1: 8290557: tools/jpackage/share/AddLauncherTest.java#id1 failed with "ERROR: Failed: Check icon file"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 26, 2022
@openjdk openjdk bot closed this Jul 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@simonis @eastig Pushed as commit 330adc0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants