8292158: AES-CTR cipher state corruption with AVX-512

[AJ-Ferguson]

Fix cipher state corruption when encrypting/decrypting less than 16 bytes at a time.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292158: AES-CTR cipher state corruption with AVX-512

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Smita Kamath (@smita-kamath - Author) ⚠️ Review applies to 360304cf
• Sandhya Viswanathan (@sviswa7 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9635/head:pull/9635
$ git checkout pull/9635

Update a local copy of the PR:
$ git checkout pull/9635
$ git pull https://git.openjdk.org/jdk pull/9635/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9635

View PR using the GUI difftool:
$ git pr show -t 9635

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9635.diff

[bridgekeeper]

👋 Welcome back AJ-Ferguson! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AJ-Ferguson The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (8fc3e429)
• 01: Full (360304cf)
• 00: Full (46a2fb9d)

[vnkozlov]

Please, add regression test.

[robcasloz]

Hi @AJ-Ferguson, please note that the JBS issue is assigned to @smita-kamath, who wrote the original implementation. Please check with Smita or other regular Intel contributors (e.g. @jatin-bhateja, @sviswa7) before moving forward with this changeset.

[smita-kamath]

@AJ-Ferguson, will take a look at the PR. Thank you.

[bridgekeeper]

@AJ-Ferguson This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[smita-kamath]

Hi @AJ-Ferguson, I have modified the changes you recommended and added a suggestion. Please have a look at the diff file and let me know what you think. Thanks.
diff.txt

[AJ-Ferguson]

Hello @smita-kamath, thank you for taking the time to look at this PR. The changes you posted look good to me. I have added your improvements and updated the branch.

[sviswa7]

@AJ-Ferguson Please do add a test for this case.

[AJ-Ferguson]

@sviswa7 @vnkozlov I have added the test. Please let me know if there are any issues.

[vnkozlov]

Good. I submitted testing.

[vnkozlov]

Testing passed.

[openjdk]

@AJ-Ferguson This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292158: AES-CTR cipher state corruption with AVX-512

Reviewed-by: kvn, svkamath, sviswanathan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• 739fdec: 8289162: runtime/NMT/ThreadedMallocTestType.java should print out memory allocations to help debug
• a11477c: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment
• 7151128: 8294317: Insufficient build rules for tzdb.dat
• fb4979c: 8290401: Support dump all phases and print nodes in ascending order of index
• 112ca2b: 8293964: Unused check_for_duplicates parameter in ClassLoaderExt::process_jar_manifest
• 99017b0: 8293064: Remove unused NET_xxx functions
• 3419363: 8294361: Cleanup usages of StringBuffer in SQLOutputImpl
• 1abf971: 8249627: Degrade Thread.suspend and Thread.resume
• bc12e95: 8292969: Bad Thread Utilization in ForkJoinPool
• dd51f7e: 8293996: C2: fix and simplify IdealLoopTree::do_remove_empty_loop
• ... and 44 more: https://git.openjdk.org/jdk/compare/800e68d6906734242119e4ea033422f037a79857...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @sviswa7) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[sviswa7]

Looks good to me as well.

[AJ-Ferguson]

Thank you for the reviews.

/integrate

[openjdk]

@AJ-Ferguson
Your change (at version 8fc3e42) is now ready to be sponsored by a Committer.

[sviswa7]

/sponsor

[openjdk]

Going to push as commit 9d76ac8.
Since your change was applied there have been 59 commits pushed to the master branch:

• e5b65c4: 8290482: Update JNI Specification of DestroyJavaVM for better alignment with JLS, JVMS, and Java SE API Specifications
• f8d9fa8: 8294483: Remove vmTestbase/nsk/jvmti/GetThreadState tests.
• 6ad151d: 8293143: Workaround for JDK-8292217 when doing "step over" of bytecode with unresolved cp reference
• 22b59b6: 8294471: SpecTaglet is inconsistent with SpecTree for inline property
• 763d4bf: 8293592: Remove JVM_StopThread, stillborn, and related cleanup
• 739fdec: 8289162: runtime/NMT/ThreadedMallocTestType.java should print out memory allocations to help debug
• a11477c: 8289797: tools/launcher/I18NArgTest.java fails on Japanese Windows environment
• 7151128: 8294317: Insufficient build rules for tzdb.dat
• fb4979c: 8290401: Support dump all phases and print nodes in ascending order of index
• 112ca2b: 8293964: Unused check_for_duplicates parameter in ClassLoaderExt::process_jar_manifest
• ... and 49 more: https://git.openjdk.org/jdk/compare/800e68d6906734242119e4ea033422f037a79857...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sviswa7 @AJ-Ferguson Pushed as commit 9d76ac8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.