Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291002: Rename Method::build_interpreter_method_data to Method::build_profiling_method_data #9637

Closed
wants to merge 1 commit into from

Conversation

TheShermanTanker
Copy link
Contributor

@TheShermanTanker TheShermanTanker commented Jul 26, 2022

As mentioned in the review process for JDK-8290834 build_interpreter_method_data is misleading because it is actually used for creating MethodData*s throughout HotSpot, not just in the interpreter. Renamed the method to build_profiling_method_data instead to more accurately describe what it is used for.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291002: Rename Method::build_interpreter_method_data to Method::build_profiling_method_data

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9637/head:pull/9637
$ git checkout pull/9637

Update a local copy of the PR:
$ git checkout pull/9637
$ git pull https://git.openjdk.org/jdk pull/9637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9637

View PR using the GUI difftool:
$ git pr show -t 9637

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9637.diff

@TheShermanTanker TheShermanTanker marked this pull request as draft July 26, 2022 08:46
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2022

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@TheShermanTanker TheShermanTanker changed the title Rename build_interpreter_method_data -> build_profiling_method_data 8291002 Jul 26, 2022
@openjdk openjdk bot changed the title 8291002 8291002: Rename Method::build_interpreter_method_data to Method::build_profiling_method_data Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@TheShermanTanker The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jul 26, 2022
@TheShermanTanker
Copy link
Contributor Author

/label hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@TheShermanTanker
The hotspot-compiler label was successfully added.

@TheShermanTanker TheShermanTanker marked this pull request as ready for review July 26, 2022 12:13
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 26, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2022

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.
Originally only Interpreter collected profiling data.

@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291002: Rename Method::build_interpreter_method_data to Method::build_profiling_method_data

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 61e072d: 8290705: StringConcat::validate_mem_flow asserts with "unexpected user: StoreI"
  • 2bd90c2: 8284990: AArch64: Remove STXR_PREFETCH from CPU features
  • 2a1d9cf: 8289137: Automatically adapt Young/OldPLABSize and when setting only MinTLABSize
  • 4d796ee: 8290887: Unused private method in TrustManagerFactoryImpl
  • f0f78a9: 8290894: Reduce runtime of vm.lang microbenchmarks
  • 1451642: 8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName
  • 8159a1a: 8290706: Remove the support for inline contiguous allocations
  • 7318b22: 8289551: Conversions between bit representations of half precision values and floats
  • 2ae8e31: 8290669: Fix wording in sun.security.ec
  • 8939095: 8289996: Fix array range check hoisting for some scaled loop iv
  • ... and 3 more: https://git.openjdk.org/jdk/compare/a6faf5d33a09ca53e5d1c60a5ed82f2368a6e1b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 26, 2022
@TheShermanTanker
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@TheShermanTanker
Your change (at version 7acd65b) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 27, 2022

Going to push as commit 8ec3197.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 61e072d: 8290705: StringConcat::validate_mem_flow asserts with "unexpected user: StoreI"
  • 2bd90c2: 8284990: AArch64: Remove STXR_PREFETCH from CPU features
  • 2a1d9cf: 8289137: Automatically adapt Young/OldPLABSize and when setting only MinTLABSize
  • 4d796ee: 8290887: Unused private method in TrustManagerFactoryImpl
  • f0f78a9: 8290894: Reduce runtime of vm.lang microbenchmarks
  • 1451642: 8244976: vmTestbase/nsk/jdi/Event/request/request001.java doesn' initialize eName
  • 8159a1a: 8290706: Remove the support for inline contiguous allocations
  • 7318b22: 8289551: Conversions between bit representations of half precision values and floats
  • 2ae8e31: 8290669: Fix wording in sun.security.ec
  • 8939095: 8289996: Fix array range check hoisting for some scaled loop iv
  • ... and 3 more: https://git.openjdk.org/jdk/compare/a6faf5d33a09ca53e5d1c60a5ed82f2368a6e1b3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 27, 2022
@openjdk openjdk bot closed this Jul 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 27, 2022
@openjdk
Copy link

openjdk bot commented Jul 27, 2022

@TobiHartmann @TheShermanTanker Pushed as commit 8ec3197.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheShermanTanker TheShermanTanker deleted the profiling branch July 27, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants