Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291037: Move PLAB resizing mechanism to G1EvacStats #9644

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jul 26, 2022

Hi all,

please review this refactoring that moves the PLAB resizing mechanism to G1EvacStats as G1 is the only user for this functionality.

The change is split into two commits for easier review: 65eef64 only moves the code, 028e3ad tries to improve it a bit.

Note that this change also removes the old, unused PLAB re-sizing algorithm previously used by CMS, hence the relatively large count of deleted LOC.

Testing: gha, gc/g1

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291037: Move PLAB resizing mechanism to G1EvacStats

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9644/head:pull/9644
$ git checkout pull/9644

Update a local copy of the PR:
$ git checkout pull/9644
$ git pull https://git.openjdk.org/jdk pull/9644/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9644

View PR using the GUI difftool:
$ git pr show -t 9644

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9644.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2022

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 26, 2022
@openjdk
Copy link

openjdk bot commented Jul 26, 2022

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jul 26, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2022

Webrevs

Copy link
Member

@sangheon sangheon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Jul 27, 2022

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291037: Move PLAB resizing mechanism to G1EvacStats

Reviewed-by: sangheki, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 861cc67: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 27, 2022
Copy link
Member

@walulyai walulyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@openjdk
Copy link

openjdk bot commented Aug 8, 2022

@tschatzl this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout submit/8291037-move-resizeplab-code
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch and removed ready Pull request is ready to be integrated labels Aug 8, 2022
@tschatzl
Copy link
Contributor Author

tschatzl commented Aug 8, 2022

Thanks @walulyai @sangheon for your reviews
/integrate

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Aug 8, 2022
@openjdk
Copy link

openjdk bot commented Aug 8, 2022

Going to push as commit 7676be8.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 861cc67: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 8, 2022
@openjdk openjdk bot closed this Aug 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 8, 2022
@openjdk
Copy link

openjdk bot commented Aug 8, 2022

@tschatzl Pushed as commit 7676be8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8291037-move-resizeplab-code branch August 10, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants