-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8290848: LoadLibraryUnload.java still fails with "Too few cleared WeakReferences" #9649
Conversation
…kReferences" Add fence to ensure WeakReferences are retained through the test
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
@RogerRiggs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Glad that you fxied this hard to find issue.
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Hello Roger, considering that the |
Hi Jai, The actions related to References are only true if the Reference (or subtype) is reachable. Note that initially the WeakReference refers to the queue not the other way around. |
Thank you Roger for that explanation. That helped. |
/integrate |
Going to push as commit c104089.
Your commit was automatically rebased without conflicts. |
@RogerRiggs Pushed as commit c104089. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The intermittent test failure was due to the WeakReferences being unreferenced too early.
Adding a Reference.reachabilityFence to the test makes it robust.
Remove from ProblemList-Xcomp.txt
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9649/head:pull/9649
$ git checkout pull/9649
Update a local copy of the PR:
$ git checkout pull/9649
$ git pull https://git.openjdk.org/jdk pull/9649/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9649
View PR using the GUI difftool:
$ git pr show -t 9649
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9649.diff