8291060: OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE

[gerard-ziemski]

On macOS we are currently using setrlimit(RLIMIT_NOFILE, OPEN_MAX) for MaxFDLimit (it's ON by default), but we can go higher than that.

My own testing on macOS 12.3.1 reveals that we can ask for setrlimit(RLIMIT_NOFILE, RLIM_INFINITY), though in reality we will get back 32765, which is still more than OPEN_MAX (10240)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291060: OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9650/head:pull/9650
$ git checkout pull/9650

Update a local copy of the PR:
$ git checkout pull/9650
$ git pull https://git.openjdk.org/jdk pull/9650/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9650

View PR using the GUI difftool:
$ git pr show -t 9650

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9650.diff

[bridgekeeper]

👋 Welcome back gziemski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gerard-ziemski The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (1338eb4b)
• 00: Full (7c5a4c4f)

[dholmes-ora]

Hi Gerard,

General approach is fine. A couple of nits/suggestions.

Thanks.

[gerard-ziemski]

Hi Gerard,

General approach is fine. A couple of nits/suggestions.

Thanks.

Thank you for the review and feedback!

[dholmes-ora]

Looks good. Thanks.

[openjdk]

@gerard-ziemski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291060: OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE

Reviewed-by: dholmes, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 54a2c5a: 8290059: Do not use std::thread in panama tests
• 5214a17: 8291479: ProblemList compiler/rangechecks/TestRangeCheckHoistingScaledIV.java on ppc64le
• 471a427: 8287794: Reverse*VNode::Identity problem
• 5d1ad39: 8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false"
• 97fc8de: 8291106: ZPlatformGranuleSizeShift is redundant
• dd69a68: 8291000: C2: Purge LoadPLocked and Store*Conditional nodes
• 07f0612: 8290532: Adjust PKCS11Exception and handle more PKCS11 error codes
• 93f96d8: 8290399: [macos] Aqua LAF does not fire an action event if combo box menu is displayed
• 5d82d67: 8290034: Auto vectorize reverse bit operations.
• 348a052: 8290846: sun/tools/jstatd/JstatdTest* tests should use VM options
• ... and 18 more: https://git.openjdk.org/jdk/compare/4d796ee8abd4eabc5d5d3034f236e8f4289ca048...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

Thumbs up.

[dcubed-ojdk]

@gerard-ziemski - I see local testing described here. What Mach5 testing
has been done?

[gerard-ziemski]

@gerard-ziemski - I see local testing described here. What Mach5 testing
has been done?

Thank you for the review!

I ran Mach5 hs-tier1,...,5

[gerard-ziemski]

/integrate

[openjdk]

Going to push as commit 1df77ec.
Since your change was applied there have been 55 commits pushed to the master branch:

• fcc1195: 8290531: Loom: Parallelize a few tests more deeply
• 226b8e6: 8290885: java/lang/ProcessBuilder/PipelineLeaksFD.java fail: More or fewer pipes than expected
• 464085e: 8291558: unify print_jni_name_prefix_on and print_jni_name_suffix_on on posix platforms
• f5d1b5b: 6463708: DefaultButtonModel.setMnemonic generates ChangeEvent for no change
• 30205bb: 8290966: G1: Record number of PLAB filled and number of direct allocations
• 86ef7b2: 8289046: Undefined Behaviour in x86 class Assembler
• d61c0c7: 8290497: some tests in com/sun/jdi fail on localized Windows platform
• 7ff1969: 8290067: Show stack dimensions in UL logging when attaching threads
• 257c71c: 8290062: Remove nmethodLocker for nmethods on-stack
• d9cb410: 8290466: Default to --with-source-date=current to avoid unmodified Hotspot recompilation
• ... and 45 more: https://git.openjdk.org/jdk/compare/4d796ee8abd4eabc5d5d3034f236e8f4289ca048...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gerard-ziemski Pushed as commit 1df77ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[jaikiran]

Just a FYI - this change showed up an interesting issue while launching "ksh" from within Java which is now detailed at https://bugs.openjdk.org/browse/JDK-8299258

[gerard-ziemski]

Thank you for the note and the investigation!