8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects" #9658

rsunderbabu · 2022-07-27T14:03:34Z

Tested with all GC options

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"

Reviewers

Leonid Mesnik (@lmesnik - Reviewer) ⚠️ Review applies to 0c6c8675

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9658/head:pull/9658
$ git checkout pull/9658

Update a local copy of the PR:
$ git checkout pull/9658
$ git pull https://git.openjdk.org/jdk pull/9658/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9658

View PR using the GUI difftool:
$ git pr show -t 9658

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9658.diff

bridgekeeper · 2022-07-27T14:05:41Z

👋 Welcome back rsunderbabu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

…: failed reallocation of scalar replaced objects"

openjdk · 2022-07-27T14:12:14Z

@rsunderbabu The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

rsunderbabu · 2022-07-27T14:19:07Z

Summary of changes

Remove explicit creation of garbage, instead call GC directly.
Retain the class of functions being tested - jni, jniref, jvmti, malloc.
Only one test is retained for every class of function.

mlbridge · 2022-07-27T14:38:50Z

Webrevs

lmesnik · 2022-07-27T18:25:11Z

test/hotspot/jtreg/vmTestbase/gc/lock/LockerTest.java


        public Worker() {
            locker.enable();
        }

        public void run() {
            locker.lock();
-            GarbageUtils.eatMemory(getExecutionController(), garbageProducer);
+            WhiteBox.getWhiteBox().fullGC();


Could you add some more work for GC here: add and free objects, arrays, strings and free them. Then call WB.GC to ensure that GC is triggered.
You could add the corresponding method in GarbageUtils and always use it instead eatMemory.

Might be call WB.YoungGC while generating garbage to put something into old gen as well as in young gen

…: failed reallocation of scalar replaced objects"

rsunderbabu · 2022-08-07T14:27:28Z

Tested for all GC types - G1GC, SerialGC, ParallelGC, ZGC.

lmesnik · 2022-08-08T15:28:49Z

test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java

+            final long memChunk = testMemory / YOUNG_GC_ITERATIONS;
+            int iteration = 0;
+
+            while (stresser.continueExecution()) {


This loop never completes, while the goal is to produce some garbage and trigger GC.

stresser runs for the duration of the test, I believe. Loop completes when test duration is complete.

ough, yes, I mean that loop was completed only once, so we have only one iteration per test, while the goal is to run a lot of lock/GC/unlock iterations.

Loop won't run for just once. It will run for the duration of the test. If the test is configured to run, say, 2 mins, stresser.continueExecution() will be false after 2 mins.

exactly, however, the whole 'engageGC' method will be executed only once and always work in this loop.
So the combination of lock/engageGC()/unlock is executed only once and the test spends all it's time in 'engageGC' which is not the stress for lock/unlock and moreover could cause OOME if lock/unlock really locks GC.

so this is the algorithm you are getting at?
while( test.duration ) {
lock
engageGC (100 youngGC and 1 fullGC)
unlock
}

Yes. It is what test should do.

lmesnik · 2022-08-08T15:31:17Z

test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java

+
+            while (stresser.continueExecution()) {
+                while (iteration++ < YOUNG_GC_ITERATIONS) {
+                    byteArrayProducer.create(memChunk);


it is needed to create at least some old objects which live after young GC.
I propose to add 'tmp = byteArrayProducer.create(memChunk);' and free this tmp variable tight before WB.fullGC().
So we will have objects with different age (up to to 100).

…: failed reallocation of scalar replaced objects"

lmesnik · 2022-08-09T04:16:11Z

test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java

-                iteration = 0;
-                WhiteBox.getWhiteBox().fullGC();
+            while (++iteration < YOUNG_GC_ITERATIONS) {
+                byteArrayProducer.create(memChunk);


please add these object to array like initialAlloc to have objects of various ages in different heap gens

lmesnik · 2022-08-09T21:05:32Z

test/hotspot/jtreg/vmTestbase/gc/lock/LockerTest.java

-            locker.unlock();
+            ExecutionController stresser = getExecutionController();
+            // Use only 30% of the heap.
+            final long testMemory = 3 * Runtime.getRuntime().maxMemory() / 10;


might be better to rename to testMemorySize

I prefer to leave it as engageGC, it shows the intent better.

I meant rename testMemory to testMemorySize

Oh! I misunderstood. Will submit changes.

openjdk · 2022-08-09T21:07:33Z

@rsunderbabu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"

Reviewed-by: lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 425 new commits pushed to the master branch:

76ee549: 8292329: Enable CDS shared heap for zero builds
14623c6: 8292739: Invalid legacy entries may be returned by Provider.getServices() call
568be58: 8290469: Add new positioning options to PassFailJFrame test framework
69448f9: 8292679: Simplify thread creation in gtest and port 2 tests to new way
3c2289d: 8215916: The failure reason of an optional JAAS LoginModule is not logged
71ab5c9: 8292816: GPL Classpath exception missing from assemblyprefix.h
c062397: 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses
a45a4b9: 8292194: G1 nmethod entry barrier disarm value wraps around too early
d3fed12: 8292864: Remove resourceHash.hpp from header files
b653b9c: 8291969: Convert LoaderConstraintsTable to ResourceHashtable
... and 415 more: https://git.openjdk.org/jdk/compare/2ff22087f209f9bd8e82d1c2a90c44cafd9ffef0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

rsunderbabu · 2022-08-10T00:13:37Z

/integrate

openjdk · 2022-08-10T00:15:32Z

@rsunderbabu
Your change (at version 0c6c867) is now ready to be sponsored by a Committer.

…: failed reallocation of scalar replaced objects"

lmesnik · 2022-08-24T19:30:49Z

/sponsor

openjdk · 2022-08-24T19:32:26Z

@lmesnik The PR has been updated since the change author (@rsunderbabu) issued the integrate command - the author must perform this command again.

rsunderbabu · 2022-08-25T00:35:16Z

/integrate

openjdk · 2022-08-25T00:36:46Z

@rsunderbabu
Your change (at version f9b0c37) is now ready to be sponsored by a Committer.

lmesnik · 2022-08-25T01:35:12Z

/sponsor

openjdk · 2022-08-25T01:38:08Z

Going to push as commit 7b81a9c.
Since your change was applied there have been 425 commits pushed to the master branch:

76ee549: 8292329: Enable CDS shared heap for zero builds
14623c6: 8292739: Invalid legacy entries may be returned by Provider.getServices() call
568be58: 8290469: Add new positioning options to PassFailJFrame test framework
69448f9: 8292679: Simplify thread creation in gtest and port 2 tests to new way
3c2289d: 8215916: The failure reason of an optional JAAS LoginModule is not logged
71ab5c9: 8292816: GPL Classpath exception missing from assemblyprefix.h
c062397: 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses
a45a4b9: 8292194: G1 nmethod entry barrier disarm value wraps around too early
d3fed12: 8292864: Remove resourceHash.hpp from header files
b653b9c: 8291969: Convert LoaderConstraintsTable to ResourceHashtable
... and 415 more: https://git.openjdk.org/jdk/compare/2ff22087f209f9bd8e82d1c2a90c44cafd9ffef0...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-08-25T01:38:33Z

@lmesnik @rsunderbabu Pushed as commit 7b81a9c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

initial commit

85a4748

8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space…

8a70905

…: failed reallocation of scalar replaced objects"

openjdk bot added the rfr Pull request is ready for review label Jul 27, 2022

openjdk bot added the hotspot hotspot-dev@openjdk.org label Jul 27, 2022

lmesnik suggested changes Jul 27, 2022

View reviewed changes

8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space…

3d0e394

…: failed reallocation of scalar replaced objects"

lmesnik reviewed Aug 8, 2022

View reviewed changes

rsunderbabu added 2 commits August 9, 2022 08:44

8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space…

24581de

…: failed reallocation of scalar replaced objects"

8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space…

0c6c867

…: failed reallocation of scalar replaced objects"

lmesnik approved these changes Aug 9, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 9, 2022

openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 10, 2022

openjdk bot removed the sponsor Pull request is ready to be sponsored label Aug 10, 2022

8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space…

f9b0c37

…: failed reallocation of scalar replaced objects"

openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 25, 2022

openjdk bot added the integrated Pull request has been integrated label Aug 25, 2022

openjdk bot closed this Aug 25, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 25, 2022

rsunderbabu deleted the 8289764 branch October 16, 2022 03:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects" #9658

8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects" #9658

rsunderbabu commented Jul 27, 2022 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jul 27, 2022

openjdk bot commented Jul 27, 2022

rsunderbabu commented Jul 27, 2022

mlbridge bot commented Jul 27, 2022 •

edited

Loading

lmesnik Jul 27, 2022

rsunderbabu commented Aug 7, 2022

lmesnik Aug 8, 2022

rsunderbabu Aug 8, 2022

lmesnik Aug 8, 2022

rsunderbabu Aug 8, 2022

lmesnik Aug 8, 2022

rsunderbabu Aug 8, 2022

lmesnik Aug 8, 2022

lmesnik Aug 8, 2022

lmesnik Aug 9, 2022

lmesnik Aug 9, 2022

rsunderbabu Aug 10, 2022

lmesnik Aug 10, 2022

rsunderbabu Aug 10, 2022

openjdk bot commented Aug 9, 2022 •

edited

Loading

rsunderbabu commented Aug 10, 2022

openjdk bot commented Aug 10, 2022

lmesnik commented Aug 24, 2022

openjdk bot commented Aug 24, 2022

rsunderbabu commented Aug 25, 2022

openjdk bot commented Aug 25, 2022

lmesnik commented Aug 25, 2022

openjdk bot commented Aug 25, 2022

openjdk bot commented Aug 25, 2022

8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects" #9658

8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects" #9658

Conversation

rsunderbabu commented Jul 27, 2022 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jul 27, 2022

openjdk bot commented Jul 27, 2022

rsunderbabu commented Jul 27, 2022

mlbridge bot commented Jul 27, 2022 • edited Loading

Webrevs

Choose a reason for hiding this comment

rsunderbabu commented Aug 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openjdk bot commented Aug 9, 2022 • edited Loading

rsunderbabu commented Aug 10, 2022

openjdk bot commented Aug 10, 2022

lmesnik commented Aug 24, 2022

openjdk bot commented Aug 24, 2022

rsunderbabu commented Aug 25, 2022

openjdk bot commented Aug 25, 2022

lmesnik commented Aug 25, 2022

openjdk bot commented Aug 25, 2022

openjdk bot commented Aug 25, 2022

rsunderbabu commented Jul 27, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Jul 27, 2022 •

edited

Loading

openjdk bot commented Aug 9, 2022 •

edited

Loading