Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291358: Fix the "overridding" typo #9660

Closed
wants to merge 1 commit into from

Conversation

pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Jul 27, 2022

Please review this trivial grammar fix. I checked that this @summary is not a summary of a commit in openjdk/jdk, so no harm in fixing it now:

* @summary Verify the presence visible members in the case of
*          member hiding and overriding.

That said, the @summary is still a broken sentence, which I'm not trying to fix beyond addressing the typo in question.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9660/head:pull/9660
$ git checkout pull/9660

Update a local copy of the PR:
$ git checkout pull/9660
$ git pull https://git.openjdk.org/jdk pull/9660/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9660

View PR using the GUI difftool:
$ git pr show -t 9660

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9660.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2022

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8291358 8291358: Fix the "overridding" typo Jul 27, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 27, 2022
@openjdk
Copy link

openjdk bot commented Jul 27, 2022

@pavelrappo The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label Jul 27, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 27, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 27, 2022

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291358: Fix the "overridding" typo

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 27, 2022
@pavelrappo
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 27, 2022

Going to push as commit c1a3347.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 37b08c7: 8237913: G1CollectedHeap::heap_region_containing shouldn't be a template

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 27, 2022
@openjdk openjdk bot closed this Jul 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 27, 2022
@openjdk
Copy link

openjdk bot commented Jul 27, 2022

@pavelrappo Pushed as commit c1a3347.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
2 participants