6383195: javax.crypto.spec.PBEKeySpec is not thread safe

[bradfordwetmore]

Simple fix to a long-standing threading bug to help clear the bug backlog.

Without the synchronized, the test case fails almost immediately.

Running JPRT with tier1/tier2.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-6383195: javax.crypto.spec.PBEKeySpec is not thread safe

Reviewers

• Weijun Wang (@wangweij - Reviewer) ⚠️ Review applies to 13b296e4

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9668/head:pull/9668
$ git checkout pull/9668

Update a local copy of the PR:
$ git checkout pull/9668
$ git pull https://git.openjdk.org/jdk pull/9668/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9668

View PR using the GUI difftool:
$ git pr show -t 9668

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9668.diff

[bridgekeeper]

👋 Welcome back wetmore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bradfordwetmore The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (b27a361f)
• 01: Full - Incremental (c932188b)
• 00: Full (13b296e4)

[wangweij]

LGTM.

BTW, how often can you observe a test failure before the code change?

[openjdk]

@bradfordwetmore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6383195: javax.crypto.spec.PBEKeySpec is not thread safe

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• e052d7f: 8288477: nmethod header size reduction
• 54a2c5a: 8290059: Do not use std::thread in panama tests
• 5214a17: 8291479: ProblemList compiler/rangechecks/TestRangeCheckHoistingScaledIV.java on ppc64le
• 471a427: 8287794: Reverse*VNode::Identity problem
• 5d1ad39: 8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false"
• 97fc8de: 8291106: ZPlatformGranuleSizeShift is redundant
• dd69a68: 8291000: C2: Purge LoadPLocked and Store*Conditional nodes
• 07f0612: 8290532: Adjust PKCS11Exception and handle more PKCS11 error codes
• 93f96d8: 8290399: [macos] Aqua LAF does not fire an action event if combo box menu is displayed
• 5d82d67: 8290034: Auto vectorize reverse bit operations.
• ... and 3 more: https://git.openjdk.org/jdk/compare/c1a3347f1731d96621f0769363c10e76156cdf19...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bradfordwetmore]

BTW, how often can you observe a test failure before the code change?

Usually 1-3 times through the loop.

Testing: 
...
java.lang.RuntimeException: Inconsistent Password: 
	at PBEKeySpecRacing.lambda$main$0(PBEKeySpecRacing.java:61)
	at java.base/java.lang.Thread.run(Thread.java:1589)

I have one more tweak to make, will come back to this soon.

[bradfordwetmore]

/integrate

[openjdk]

Going to push as commit 791fc57.
Since your change was applied there have been 13 commits pushed to the master branch:

• e052d7f: 8288477: nmethod header size reduction
• 54a2c5a: 8290059: Do not use std::thread in panama tests
• 5214a17: 8291479: ProblemList compiler/rangechecks/TestRangeCheckHoistingScaledIV.java on ppc64le
• 471a427: 8287794: Reverse*VNode::Identity problem
• 5d1ad39: 8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false"
• 97fc8de: 8291106: ZPlatformGranuleSizeShift is redundant
• dd69a68: 8291000: C2: Purge LoadPLocked and Store*Conditional nodes
• 07f0612: 8290532: Adjust PKCS11Exception and handle more PKCS11 error codes
• 93f96d8: 8290399: [macos] Aqua LAF does not fire an action event if combo box menu is displayed
• 5d82d67: 8290034: Auto vectorize reverse bit operations.
• ... and 3 more: https://git.openjdk.org/jdk/compare/c1a3347f1731d96621f0769363c10e76156cdf19...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bradfordwetmore Pushed as commit 791fc57.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.