Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth #9678

Closed
wants to merge 6 commits into from

Conversation

TheShermanTanker
Copy link
Contributor

@TheShermanTanker TheShermanTanker commented Jul 28, 2022

EXIT_FAILURE is defined as -1 in NativeCreds.c, and is not only unused, but also incorrect, as it incorrectly redefines the existing EXIT_FAILURE, which is actually 1 on Windows, not -1. Can be safely commented out as it isn't used anywhere, except for in a call to ExitProcess which has also been commented out as well.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9678/head:pull/9678
$ git checkout pull/9678

Update a local copy of the PR:
$ git checkout pull/9678
$ git pull https://git.openjdk.org/jdk pull/9678/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9678

View PR using the GUI difftool:
$ git pr show -t 9678

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9678.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2022

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8291511 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth Jul 28, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 28, 2022
@openjdk
Copy link

openjdk bot commented Jul 28, 2022

@TheShermanTanker The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jul 28, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2022

Webrevs

@TheShermanTanker
Copy link
Contributor Author

Successfully merged with latest, awaiting review and/or sponsorship

@TheShermanTanker
Copy link
Contributor Author

Merged with latest, review pending

@wangweij
Copy link
Contributor

wangweij commented Aug 15, 2022

Changes looks good to me. Can you also remove the unused ExitProcess call as well? Thanks.

@TheShermanTanker
Copy link
Contributor Author

I did contemplate doing so, but I think it may have been commented out instead of being completely removed for a reason, do we really not need it anymore?

@wangweij
Copy link
Contributor

I don't think a library should call ExitProcess anyway. If you do want to keep it, I'd suggest modify that EXIT_FAILURE argument to -1, which is what the original author meant. Or, move the useless #define EXIT_FAILURE -1 line there and also comment it out. This way we keep the history.

@openjdk
Copy link

openjdk bot commented Aug 15, 2022

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 15, 2022
@TheShermanTanker
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 15, 2022
@openjdk
Copy link

openjdk bot commented Aug 15, 2022

@TheShermanTanker
Your change (at version ac7e7e5) is now ready to be sponsored by a Committer.

@wangweij
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 15, 2022

Going to push as commit b00eede.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 15, 2022
@openjdk openjdk bot closed this Aug 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 15, 2022
@openjdk
Copy link

openjdk bot commented Aug 15, 2022

@wangweij @TheShermanTanker Pushed as commit b00eede.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheShermanTanker TheShermanTanker deleted the patch-2 branch August 15, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants