Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290740: Catalog not used when the handler is null #9682

Closed
wants to merge 1 commit into from

Conversation

JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Jul 29, 2022

Patch to make sure the Catalog is used even when the handler is null.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290740: Catalog not used when the handler is null

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9682/head:pull/9682
$ git checkout pull/9682

Update a local copy of the PR:
$ git checkout pull/9682
$ git pull https://git.openjdk.org/jdk pull/9682/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9682

View PR using the GUI difftool:
$ git pr show -t 9682

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9682.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2022

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 29, 2022
@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@JoeWang-Java The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 29, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 29, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290740: Catalog not used when the handler is null

Reviewed-by: lancea, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • cc2861a: 8290901: Reduce use of -source in langtools tests
  • 64a1a08: 8289647: AssertionError during annotation processing of record related tests
  • 95fc16b: 8290525: Move HeapRegion::_compaction_top to G1FullCollector
  • f58e08e: 8290715: Fix incorrect uses of G1CollectedHeap::heap_region_containing()
  • 18cd16d: 8291003: ARM32: constant_table.size assertion
  • cfe9026: 8289511: Improve test coverage for XPath Axes: child

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 29, 2022
@JoeWang-Java
Copy link
Member Author

Thanks all!

@JoeWang-Java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 30, 2022

Going to push as commit 470c0eb.
Since your change was applied there have been 10 commits pushed to the master branch:

  • dd9bd31: 8289688: jfr command hangs when it processes invalid file
  • 8179a19: 8290243: move seeTagToContent from HtmlDocletWriter to TagletWriterImpl
  • 15943e4: 8282666: nsk/jvmti/PopFrame/popframe004 failed with: TEST FAILED: 30 JVMTI events were generated by the function PopFrame()
  • 0bcf176: 6227536: KeyGenerator.init() methods do not throw IllegalArgumentException for keysize == 0
  • cc2861a: 8290901: Reduce use of -source in langtools tests
  • 64a1a08: 8289647: AssertionError during annotation processing of record related tests
  • 95fc16b: 8290525: Move HeapRegion::_compaction_top to G1FullCollector
  • f58e08e: 8290715: Fix incorrect uses of G1CollectedHeap::heap_region_containing()
  • 18cd16d: 8291003: ARM32: constant_table.size assertion
  • cfe9026: 8289511: Improve test coverage for XPath Axes: child

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 30, 2022
@openjdk openjdk bot closed this Jul 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 30, 2022
@openjdk
Copy link

openjdk bot commented Jul 30, 2022

@JoeWang-Java Pushed as commit 470c0eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JoeWang-Java JoeWang-Java deleted the JDK-8290740 branch July 30, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants