8290885: java/lang/ProcessBuilder/PipelineLeaksFD.java fail: More or fewer pipes than expected

[RogerRiggs]

The test java/lang/ProcessBuilder/PipelineLeaksFD.java fails intermittently, usually associated with fastdebug and -Xcomp.
It reports extra file descriptors are open that not expected.
The test of pipelines did not explicitly use or close the stderr streams of each stream except the last.
The intermittent nature of the failure is due to the non-deterministic GC interactions that close the streams when they become un-referenced.

The solution in this case is to redirect the error stream to the stdout stream for each pipeline stage except the last.

The test is removed from the ProblemList-Xcomp.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290885: java/lang/ProcessBuilder/PipelineLeaksFD.java fail: More or fewer pipes than expected

Reviewers

• Brian Burkhalter (@bplb - Reviewer)
• Naoto Sato (@naotoj - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9687/head:pull/9687
$ git checkout pull/9687

Update a local copy of the PR:
$ git checkout pull/9687
$ git pull https://git.openjdk.org/jdk pull/9687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9687

View PR using the GUI difftool:
$ git pr show -t 9687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9687.diff

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

⚠️ @RogerRiggs This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[openjdk]

@RogerRiggs The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2ad961d3)

[bplb]

Looks reasonable.

[openjdk]

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290885: java/lang/ProcessBuilder/PipelineLeaksFD.java fail: More or fewer pipes than expected

Reviewed-by: bpb, naoto, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 470c0eb: 8290740: Catalog not used when the handler is null
• dd9bd31: 8289688: jfr command hangs when it processes invalid file
• 8179a19: 8290243: move seeTagToContent from HtmlDocletWriter to TagletWriterImpl
• 15943e4: 8282666: nsk/jvmti/PopFrame/popframe004 failed with: TEST FAILED: 30 JVMTI events were generated by the function PopFrame()
• 0bcf176: 6227536: KeyGenerator.init() methods do not throw IllegalArgumentException for keysize == 0
• cc2861a: 8290901: Reduce use of -source in langtools tests
• 64a1a08: 8289647: AssertionError during annotation processing of record related tests
• 95fc16b: 8290525: Move HeapRegion::_compaction_top to G1FullCollector
• f58e08e: 8290715: Fix incorrect uses of G1CollectedHeap::heap_region_containing()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[naotoj]

This loop could be removed by doing redirects in the data provider.

[RogerRiggs]

Thanks for the review.
The effect would be the same, though it would distribute the needed constraint to more places in the source and the descriptive comment would need to be duplicated.

[RogerRiggs]

/integrate

[openjdk]

Going to push as commit 226b8e6.
Since your change was applied there have been 20 commits pushed to the master branch:

• 464085e: 8291558: unify print_jni_name_prefix_on and print_jni_name_suffix_on on posix platforms
• f5d1b5b: 6463708: DefaultButtonModel.setMnemonic generates ChangeEvent for no change
• 30205bb: 8290966: G1: Record number of PLAB filled and number of direct allocations
• 86ef7b2: 8289046: Undefined Behaviour in x86 class Assembler
• d61c0c7: 8290497: some tests in com/sun/jdi fail on localized Windows platform
• 7ff1969: 8290067: Show stack dimensions in UL logging when attaching threads
• 257c71c: 8290062: Remove nmethodLocker for nmethods on-stack
• d9cb410: 8290466: Default to --with-source-date=current to avoid unmodified Hotspot recompilation
• acbe093: 8291559: x86: compiler/vectorization/TestReverseBitsVector.java fails
• 32d410a: 8290868: NMT: MallocSiteTable statistics improvements
• ... and 10 more: https://git.openjdk.org/jdk/compare/18cd16d2eae2ee624827eb86621f3a4ffd98fe8c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RogerRiggs Pushed as commit 226b8e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.