8289049: x86_32 build fails with GCC 11 due to newString646_US warning

[shipilev]

See bug report for reproducer and error message. The warning looks quite superficial, and I initially suspected that it complains about int len = (int)strlen(str) cast of size_t. But what is confusing is nearly the similar code in newStringCp1252 apparently does not produce the warning:

jdk/src/java.base/share/native/libjava/jni_util.c

Lines 533 to 566 in f5d1b5b

	static jstring
	newStringCp1252(JNIEnv *env, const char *str)
	{
	int len = (int) strlen(str);
	jchar buf[512];
	jchar *str1;
	jstring result;
	int i;
	if ((*env)->EnsureLocalCapacity(env, 1) < 0)
	return NULL;
	if (len > 512) {
	str1 = (jchar *)malloc(len * sizeof(jchar));
	if (str1 == 0) {
	JNU_ThrowOutOfMemoryError(env, 0);
	return 0;
	}
	} else
	str1 = buf;
	for (i=0; i<len; i++) {
	unsigned char c = (unsigned char)str[i];
	if ((c >= 0x80) && (c <= 0x9f))
	str1[i] = cp1252c1chars[c-128];
	else
	str1[i] = c;
	}
	result = (*env)->NewString(env, str1, len);
	if (str1 != buf)
	free(str1);
	return result;
	}

I propose we chalk it up to false/odd compiler warning and sync up unproblematic newStringCp1252 and newString646_US implementation to dodge it.

Additional testing:

• Linux x86_32 build with GCC 11
• Linux x86_32 tier1 test with GCC 9
• Linux x86_64 tier1 test with GCC 9

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8289049: x86_32 build fails with GCC 11 due to newString646_US warning

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9702/head:pull/9702
$ git checkout pull/9702

Update a local copy of the PR:
$ git checkout pull/9702
$ git pull https://git.openjdk.org/jdk pull/9702/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9702

View PR using the GUI difftool:
$ git pr show -t 9702

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9702.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (c2546de4)
• 01: Full - Incremental (adcbf91c)
• 00: Full (82ff99b3)

[shipilev]

Any thoughts?

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289049: x86_32 build fails with GCC 11 due to newString646_US warning

Reviewed-by: alanb, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• f75da22: 8292395: [testbug] VectorGatherScatterTest.java fails on SVE with -XX:MaxVectorSize=8 after JDK-8288397
• 802ef38: 8292327: java.io.EOFException in InflaterInputStream after JDK-8281962
• e61f6fc: 8292362: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed on some platforms
• 0bfb121: 8292051: jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java failed "AssertionError: Expected terminated values: [666] but got: []"
• 1d9c2f7: 8292279: (fs) Use try-with-resources to release NativeBuffer
• a25e1dc: 8292285: C2: remove unreachable block after NeverBranch-to-Goto conversion
• 1ef4e48: 8273860: Javadoc Deprecated API list should not use italic font for description column
• 0cc66ae: 8285790: AArch64: Merge C2 NEON and SVE matching rules
• da477b1: 8292509: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java on windows
• 01b87ba: 8289616: Drop use of Thread.stop in AppContext
• ... and 18 more: https://git.openjdk.org/jdk/compare/e89abb7d2d902c6e6b3c9953fc6663de10db77b9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thank you! Any other comments? I'll be integrating it soon otherwise.

[tstuefe]

I'm confused. How does adding EnsureCapacity in newString646_US fix the compiler warning mentioned in JBS?

[shipilev]

I'm confused. How does adding EnsureCapacity in newString646_US fix the compiler warning mentioned in JBS?

I think this is a bona-fide compiler static analyzer bug. GCC 12 compiles this code fine. So, we have two options: a) disable the warnings for this code block; b) harmonize all code blocks to use the same style, which is also incidentally avoids the false warning. This PR does (b).

[tstuefe]

Looks good.

[tstuefe]

I'm confused. How does adding EnsureCapacity in newString646_US fix the compiler warning mentioned in JBS?

I think this is a bona-fide compiler static analyzer bug. GCC 12 compiles this code fine. So, we have two options: a) disable the warnings for this code block; b) harmonize all code blocks to use the same style, which is also incidentally avoids the false warning. This PR does (b).

Okay, fair enough.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit 0c67fba.
Since your change was applied there have been 30 commits pushed to the master branch:

• bf7d6d3: 7132413: [macosx] closed/javax/swing/AbstractButton/5049549/bug5049549.java fails on MacOS
• e230719: 8292448: Convert BitMapFragmentTable to ResourceHashtable
• f75da22: 8292395: [testbug] VectorGatherScatterTest.java fails on SVE with -XX:MaxVectorSize=8 after JDK-8288397
• 802ef38: 8292327: java.io.EOFException in InflaterInputStream after JDK-8281962
• e61f6fc: 8292362: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed on some platforms
• 0bfb121: 8292051: jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java failed "AssertionError: Expected terminated values: [666] but got: []"
• 1d9c2f7: 8292279: (fs) Use try-with-resources to release NativeBuffer
• a25e1dc: 8292285: C2: remove unreachable block after NeverBranch-to-Goto conversion
• 1ef4e48: 8273860: Javadoc Deprecated API list should not use italic font for description column
• 0cc66ae: 8285790: AArch64: Merge C2 NEON and SVE matching rules
• ... and 20 more: https://git.openjdk.org/jdk/compare/e89abb7d2d902c6e6b3c9953fc6663de10db77b9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 0c67fba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.