Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4850101: Setting mnemonic to VK_F4 underlines the letter S in a button. #9712

Closed
wants to merge 4 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Aug 2, 2022

It is seen that using VK_F4 in JButton's setMnemonic(int i), causes the letter 'S' in the JButton to be underlined if JButton's text has 'S' in its string.
This is because VK_F4 keycode is 0x73 (115 in decimal) which happens to be value of lowercase 's' so as per the logic implemented in SwingUtilities.findDisplayedMnemonicIndex(), the first index of the character (either lowecasr or uppercase) is returned as a mnemonic, which gets underlined.

Fix is made to ignore Action Keys from VK_F1->VK_F11 as displayed mnemonic which corresponds to lowercase p->z


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-4850101: Setting mnemonic to VK_F4 underlines the letter S in a button.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9712/head:pull/9712
$ git checkout pull/9712

Update a local copy of the PR:
$ git checkout pull/9712
$ git pull https://git.openjdk.org/jdk pull/9712/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9712

View PR using the GUI difftool:
$ git pr show -t 9712

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9712.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 2, 2022
@openjdk
Copy link

openjdk bot commented Aug 2, 2022

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Aug 2, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2022

Webrevs

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me although I'm not an expert on mnemonic handling.

@openjdk
Copy link

openjdk bot commented Aug 4, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

4850101: Setting mnemonic to VK_F4 underlines the letter S in a button.

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 428 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 4, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 11, 2022

Mailing list message from Patrick Chen on client-libs-dev:

is it the only case ?
is there other keycode with the same issue?

Le mar. 2 ao?t 2022 ? 12:47, Prasanta Sadhukhan <psadhukhan at openjdk.org> a
?crit :

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20220802/cb2b6570/attachment-0001.htm>

@prsadhuk
Copy link
Contributor Author

@prrace The code is changed since last approved..Do you have any objection?

@prsadhuk
Copy link
Contributor Author

prsadhuk commented Sep 7, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 7, 2022

Going to push as commit d696104.
Since your change was applied there have been 693 commits pushed to the master branch:

  • 14fd1b6: 8292921: Rewrite object field printer
  • 4f9065d: 8293333: Broken links in JDI specification
  • 2259e42: 8293197: Avoid double racy reads from non-volatile fields in SharedSecrets
  • 205f992: 8293326: jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java slow on Windows
  • 710a143: 8293445: clhsdb "thread" command gives incorrect error message for bad threadID
  • 57930f8: 8293285: x86_64: Move libm stub implementations to StubGenerator
  • 5b4c415: 8293254: x86_64: Extract arraycopy stub implementations into a separate file
  • fb6eb6f: 8293245: x86_64: Extract Adler32 stub implementation into stubGenerator_x86_64_adler.cpp
  • da59618: 8264744: (fs) Use file cloning in Linux version of Files::copy method
  • 85d4b49: 8283929: GHA: Add RISC-V build config
  • ... and 683 more: https://git.openjdk.org/jdk/compare/46251bc6e248a19e8d78173ff8d0502c68ee1acb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 7, 2022
@openjdk openjdk bot closed this Sep 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2022
@openjdk
Copy link

openjdk bot commented Sep 7, 2022

@prsadhuk Pushed as commit d696104.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-4850101 branch September 7, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants