8291799: IGV: make "Selection mode" a toggle button

[tobiasholenstein]

In IGV, an open graph has two modes for interaction:
Panning mode where the user can move the graph with the mouse.

Selection mode where the user can draw a selection rectangle with the mouse to select multiple nodes. This mode can also be accessed by holding down the CMD/Ctrl key on the keyboard.

We remove the Panning Mode button (and the action PanModeAction.java) and make the Select Mode button (triggers SelectionModeAction.java) a toggle button:
When it is selected, the user is in Selection Mode

Otherwise the user is in Panning Mode (default)

This image shows a user that is selecting multiple nodes using the Panning Mode toggle button:

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291799: IGV: make "Selection mode" a toggle button

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)
• Roberto Castañeda Lozano (@robcasloz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9725/head:pull/9725
$ git checkout pull/9725

Update a local copy of the PR:
$ git checkout pull/9725
$ git pull https://git.openjdk.org/jdk pull/9725/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9725

View PR using the GUI difftool:
$ git pr show -t 9725

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9725.diff

[bridgekeeper]

👋 Welcome back tholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tobiasholenstein The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0a32370a)

[vnkozlov]

Good.

[openjdk]

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291799: IGV: make "Selection mode" a toggle button

Reviewed-by: kvn, thartmann, rcastanedalo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 0bc804d: 8291762: Backout JDK-8291757 from jdk/jdk
• 3493973: Merge
• 43bb399: 8291757: Remove EA from JDK 19 version string starting with Initial RC promotion B35 on August 11, 2022
• 4772354: 8291825: java/time/nontestng/java/time/zone/CustomZoneNameTest.java fails if defaultLocale and defaultFormatLocale are different
• 1a6c83b: 8291798: VMRegImpl::print_on is broken after JDK-8289060
• b6b0317: 8290840: Refactor the "os" class
• 4cfbb3b: Merge
• e265b2a: 8290867: Race freeing remembered set segments
• 13f0f12: 8290370: Convert SymbolPropertyTable to ResourceHashtable
• 67f0011: 8260892: Compilation fails: lambda parameter not visible in body when generics involved
• ... and 7 more: https://git.openjdk.org/jdk/compare/0971d3464609bf4124df460ea73ff761d7e0f7b2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good to me too!

[robcasloz]

Looks good!

[tobiasholenstein]

Thanks @vnkozlov, @robcasloz and @TobiHartmann for the reviews!

[tobiasholenstein]

/integrate

[openjdk]

Going to push as commit 504a626.
Since your change was applied there have been 38 commits pushed to the master branch:

• 6e7cd76: 8291061: Improve thread safety of FileTime.toString and toInstant
• 477f471: Merge
• 4b3dfe1: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs
• 6b2184e: 8290248: Implement MaxINode::Ideal transformation
• 27c8826: 8291840: Avoid JavaCalls for setting up _java_system_loader and _java_platform_loader
• 6e6c64c: 8291941: ProblemList java/lang/ProcessBuilder/PipelineLeaksFD.java on linux-all
• 617a196: 8290812: Add a test for ResourceHashtable
• 1edc245: 8291899: Zero VM is broken on MacOS after JDK-8290840 due to os::setup_fpu() is missing
• 6ad6b1c: 8272998: ImageIO.read() throws incorrect exception type
• 90257f9: 8169187: [macosx] Aqua: java/awt/image/multiresolution/MultiresolutionIconTest.java
• ... and 28 more: https://git.openjdk.org/jdk/compare/0971d3464609bf4124df460ea73ff761d7e0f7b2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tobiasholenstein Pushed as commit 504a626.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.