Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290709: Incorrect dominance error for unconditional pattern vs. null #9732

Closed
wants to merge 1 commit into from

Conversation

biboudis
Copy link
Member

@biboudis biboudis commented Aug 3, 2022

The corresponding JLS rule (3rd preview feature of pattern switch) on unconditional patterns & null does not exist anymore:

Check:

Effectively, the following restriction was lifted:

A switch label that has a pattern case label element p that is total for the type of the selector expression of the enclosing switch statement or switch expression dominates a switch label that has a null case label element.

The corresponding neg-tests where now promoted as pos-tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290709: Incorrect dominance error for unconditional pattern vs. null

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9732/head:pull/9732
$ git checkout pull/9732

Update a local copy of the PR:
$ git checkout pull/9732
$ git pull https://git.openjdk.org/jdk pull/9732/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9732

View PR using the GUI difftool:
$ git pr show -t 9732

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9732.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2022

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 3, 2022
@openjdk
Copy link

openjdk bot commented Aug 3, 2022

@biboudis The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Aug 3, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 3, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2022

@biboudis This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290709: Incorrect dominance error for unconditional pattern vs. null

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 347 new commits pushed to the master branch:

  • 2d10d4f: 8291651: CleanerTest.java fails with "Cleanable was cleaned"
  • bd674dc: 8293163: G1: Rename G1HeapRegionAttr::is_humongous
  • 479795b: 8293164: Remove unimplemented Generation::print_heap_change
  • 6e6202c: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures
  • 17283cf: 8293011: riscv: Duplicated stubs to interpreter for static calls
  • 6076128: 8292008: Transition the JDK to the common standard of C11
  • 6f29734: 8293178: Remove obsolete properties from javadoc resource file
  • dd54153: 8293162: Drop support for VS2017
  • 12317ef: 8293046: Move CDS command-line flags to cds_globals.hpp
  • 372fc58: 8293165: GHA: Provide necessary x86_32 packages for runtime/ErrorHandling/TestDwarf.java
  • ... and 337 more: https://git.openjdk.org/jdk/compare/a2cff2634cdaa0fa7ba2a1acd951d6f521f59f6d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lahodaj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 1, 2022
@biboudis
Copy link
Member Author

biboudis commented Sep 1, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 1, 2022
@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@biboudis
Your change (at version 009fe84) is now ready to be sponsored by a Committer.

@lahodaj
Copy link
Contributor

lahodaj commented Sep 1, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 1, 2022

Going to push as commit 9444a08.
Since your change was applied there have been 349 commits pushed to the master branch:

  • 6a1b0b5: 8293154: TemporalQueries java doc error
  • 5204528: 8293201: Library detection in runtime/ErrorHandling/TestDwarf.java fails on some systems
  • 2d10d4f: 8291651: CleanerTest.java fails with "Cleanable was cleaned"
  • bd674dc: 8293163: G1: Rename G1HeapRegionAttr::is_humongous
  • 479795b: 8293164: Remove unimplemented Generation::print_heap_change
  • 6e6202c: 8292407: Improve Weak CAS VarHandle/Unsafe tests resilience under spurious failures
  • 17283cf: 8293011: riscv: Duplicated stubs to interpreter for static calls
  • 6076128: 8292008: Transition the JDK to the common standard of C11
  • 6f29734: 8293178: Remove obsolete properties from javadoc resource file
  • dd54153: 8293162: Drop support for VS2017
  • ... and 339 more: https://git.openjdk.org/jdk/compare/a2cff2634cdaa0fa7ba2a1acd951d6f521f59f6d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 1, 2022
@openjdk openjdk bot closed this Sep 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 1, 2022
@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@lahodaj @biboudis Pushed as commit 9444a08.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants