Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291828: Reduce runtime of java.util.stream microbenchmarks #9733

Closed
wants to merge 2 commits into from

Conversation

ericcaspole
Copy link

@ericcaspole ericcaspole commented Aug 3, 2022

These changes reduce the default run time from about 1 day 22 hours to about 6 hours with good stability we can use in weekly testing.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291828: Reduce runtime of java.util.stream microbenchmarks

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9733/head:pull/9733
$ git checkout pull/9733

Update a local copy of the PR:
$ git checkout pull/9733
$ git pull https://git.openjdk.org/jdk pull/9733/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9733

View PR using the GUI difftool:
$ git pr show -t 9733

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9733.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2022

👋 Welcome back ecaspole! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 3, 2022
@openjdk
Copy link

openjdk bot commented Aug 3, 2022

@ericcaspole The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 3, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 3, 2022

Webrevs

@@ -26,6 +26,8 @@
import org.openjdk.jmh.annotations.BenchmarkMode;
import org.openjdk.jmh.annotations.Fork;
import org.openjdk.jmh.annotations.Measurement;
import org.openjdk.jmh.annotations.Fork;
import org.openjdk.jmh.annotations.Measurement;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there have been annotations for Fork to go with this import?
Importing Measurement again is a dup.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye, this one has some mistake, I will fix these and get a new time estimate overnight.

@ericcaspole
Copy link
Author

These last changes reduce the run time to about 4h45m with adequate result stability.

@openjdk
Copy link

openjdk bot commented Aug 16, 2022

@ericcaspole This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291828: Reduce runtime of java.util.stream microbenchmarks

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 153 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 16, 2022
@ericcaspole
Copy link
Author

Thanks Roger!

@ericcaspole
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 17, 2022

Going to push as commit 0fc9263.
Since your change was applied there have been 168 commits pushed to the master branch:

  • e81210f: 8292352: 32-bit Windows build failures after JDK-8290059
  • f45b840: 8292384: Convert AdapterHandlerTable to ResourceHashtable
  • 0c67fba: 8289049: x86_32 build fails with GCC 11 due to newString646_US warning
  • bf7d6d3: 7132413: [macosx] closed/javax/swing/AbstractButton/5049549/bug5049549.java fails on MacOS
  • e230719: 8292448: Convert BitMapFragmentTable to ResourceHashtable
  • f75da22: 8292395: [testbug] VectorGatherScatterTest.java fails on SVE with -XX:MaxVectorSize=8 after JDK-8288397
  • 802ef38: 8292327: java.io.EOFException in InflaterInputStream after JDK-8281962
  • e61f6fc: 8292362: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed on some platforms
  • 0bfb121: 8292051: jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java failed "AssertionError: Expected terminated values: [666] but got: []"
  • 1d9c2f7: 8292279: (fs) Use try-with-resources to release NativeBuffer
  • ... and 158 more: https://git.openjdk.org/jdk/compare/af76c0c1991f6051ba95f05b79121a7eeef8e7d3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 17, 2022
@openjdk openjdk bot closed this Aug 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@ericcaspole Pushed as commit 0fc9263.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants