8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)

[hseigel]

The JVM fails when generating oop maps for method getAlphanumericCode(int) in bug_file/com/google/zxing/qrcode/encoder/Encoder.javap because the last bytecode in the method is an unreachable conditional branch at byecode index 11131:

  11124: ireturn
  11125: iinc          41, 1
  11128: iload         41
  11130: iconst_2
  11131: if_icmple     291

The class file (Encoder.class) containing getAlphanumericCode(int) has a class file version of 49. So it is verified by the old verifier, which allows methods to end in a conditional branch provided that the conditional branch is unreachable during method execution.

This fix changes GenerateOopMap::jump_targets_do() to handle such methods.

The fix was tested by running the user's failing program, the new regression test, Mach5 tiers 1-2 on Linux, Mac OS, and Windows, Mach5 tiers 3-5 on Linu x64, and the JC Lang,VM, and API tests locally on Linux x64.

Please review.
Thanks, Harold

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)

Reviewers

• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 4c72e190
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9745/head:pull/9745
$ git checkout pull/9745

Update a local copy of the PR:
$ git checkout pull/9745
$ git pull https://git.openjdk.org/jdk pull/9745/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9745

View PR using the GUI difftool:
$ git pr show -t 9745

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9745.diff

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hseigel The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (fef2b43c)
• 01: Full - Incremental (4c72e190)
• 00: Full (bdce5b04)

[dholmes-ora]

Seems reasonable. One query on the test but nothing important.

Surprised this has not been detected in the past.

Thanks.

[dholmes-ora]

Why a package, and why this package for a runtime test ??

[hseigel]

Commit 3 removed the packages. Thanks for pointing this out.

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)

Reviewed-by: dholmes, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 87cda21: Merge
• 5963300: 8290562: ThreadMXBean.getThread{Cpu,User}Time fails with -XX:-VMContinuations
• 0657acf: 8289249: Add methods to Elements for record constructors
• b66a0d1: 8291992: [REDO2] ProblemList multiple tests in -Xcomp mode due to JDK-8291649
• 9bff3b7: 8291990: [REDO] ProblemList multiple tests in -Xcomp mode due to JDK-8291649
• f9bb367: 8291653: G1 refinement incorrectly expects always-valid HeapRegion out of the Hot Card Cache
• b17a745: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value
• 0da4314: 8288732: Reduce runtime of java.util.concurrent microbenchmarks
• 88c96dd: 8291947: riscv: fail to build after JDK-8290840
• dd7f2d9: 8290090: Change CodeBlobType from unscoped enum to enum class
• ... and 21 more: https://git.openjdk.org/jdk/compare/a3040fcc2baa48c19d9525b3539863a71fa5781d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

This looks good and like a safe fix.

[hseigel]

Thanks David and Coleen for the reviews.

/integrate

[openjdk]

Going to push as commit 8d88be2.
Since your change was applied there have been 39 commits pushed to the master branch:

• 8a804f6: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk
• 5a539e8: 8291893: riscv: remove fence.i used in user space
• b2f0cbd: 8064787: [macosx] In Nimbus LaF, Ctrl+Alt mnemonic doesn't work
• 891df21: 8259687: JTabbedPane.setComponentAt doesn't hide previously visible tab component
• d4fb91b: 8291956: Simplify the loop condition in sun.net.httpserver.Request constructor
• 20123ea: 8291901: IGV: Preference menu disappears after JDK-8288750
• 8e2c006: 8291957: Redundant import statements in sun.security.ec
• ae52053: 8291954: Use Optional.isEmpty instead of !Optional.isPresent in java.base
• 87cda21: Merge
• 5963300: 8290562: ThreadMXBean.getThread{Cpu,User}Time fails with -XX:-VMContinuations
• ... and 29 more: https://git.openjdk.org/jdk/compare/a3040fcc2baa48c19d9525b3539863a71fa5781d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@hseigel Pushed as commit 8d88be2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.