Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291949: Unexpected extending of SupportedGroups #9765

Closed
wants to merge 2 commits into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Aug 5, 2022

In the SunJSSE implementation, there are a few unexpected extending of static class SupportedGroups. It may be nice to clean them up so that the code is easier to read. Please review this simple code clean up.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9765/head:pull/9765
$ git checkout pull/9765

Update a local copy of the PR:
$ git checkout pull/9765
$ git pull https://git.openjdk.org/jdk pull/9765/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9765

View PR using the GUI difftool:
$ git pr show -t 9765

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9765.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2022

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 5, 2022
@openjdk
Copy link

openjdk bot commented Aug 5, 2022

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Aug 5, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 5, 2022

Webrevs

Copy link
Member

@djelinski djelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

Copy link
Contributor

@bradfordwetmore bradfordwetmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291949: Unexpected extending of SupportedGroups

Reviewed-by: djelinski, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

  • e70747b: 8292305: [BACKOUT] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS
  • 22d6d31: 8284313: Improve warning messages when CDS archive fails to load
  • 00decca: 8289208: Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS
  • 9f8cc42: 8292218: Convert PackageEntryTable to ResourceHashtable
  • 871b7da: 8291266: RenderPerfTest: missing content while rendering some primitives
  • 0c40128: 7194212: NPE in Flow.visitIdent
  • 6eb7c3a: 8290732: JNI DestroyJavaVM can start shutdown when one non-daemon thread remains
  • 083e014: 8292233: Increase symtab hash table size
  • 45e5b31: 8292244: Remove unnecessary include directories
  • 9bfffa0: 8291945: Add OSInfo API for static OS information
  • ... and 38 more: https://git.openjdk.org/jdk/compare/aff7689a00a72c4e508d813372f519bace6b77ab...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 12, 2022
@XueleiFan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 15, 2022

Going to push as commit ea2c82e.
Since your change was applied there have been 63 commits pushed to the master branch:

  • b5707b0: 8292196: Reduce runtime of java.util.regex microbenchmarks
  • b00eede: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth
  • 3a09077: 8291337: Reduce runtime of vm.lamdba microbenchmarks
  • dd2034b: 8291972: Fix double copy of arguments when thawing two interpreted frames
  • aa5b718: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
  • 695bb39: 8292347: Remove unused Type::is_ptr_to_boxing_obj
  • ec96b1f: 8290291: G1: Merge multiple calls of block_size in HeapRegion::block_start
  • fd4b2f2: 8291718: Remove mark_for_deoptimization from klass unloading
  • 9d7c13e: 8155246: Throw error if default java.security file is missing
  • e89abb7: 8292190: [IR Framework] Remove redundant regex matching for failing counts constraints
  • ... and 53 more: https://git.openjdk.org/jdk/compare/aff7689a00a72c4e508d813372f519bace6b77ab...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 15, 2022
@openjdk openjdk bot closed this Aug 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 15, 2022
@openjdk
Copy link

openjdk bot commented Aug 15, 2022

@XueleiFan Pushed as commit ea2c82e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8291949 branch November 13, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
3 participants