-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8227651: Tests fail with SSLProtocolException: Input record too big #9773
Conversation
/issue add 8212096 |
👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into |
@djelinski |
@djelinski The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@djelinski This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 72 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Could it be a TLS implementation problem that the server should not read application data as handshaking data? |
Not really; There are 2 problems with the existing implementation:
Both are fixed here. |
Thank you for the details. |
/integrate |
Going to push as commit 7b029ea.
Your commit was automatically rebased without conflicts. |
@djelinski Pushed as commit 7b029ea. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Fix
SSLEngineService
test class to make sure it does not discard any network data betweenhandshaking
andreceive
.With TLS1.3 the client starts sending application data immediately after sending the Finished message. The server may read some of that data in the
handshaking
method. This patch makes sure that any such data is delivered to thereceive
method for processing.Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9773/head:pull/9773
$ git checkout pull/9773
Update a local copy of the PR:
$ git checkout pull/9773
$ git pull https://git.openjdk.org/jdk pull/9773/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9773
View PR using the GUI difftool:
$ git pr show -t 9773
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9773.diff