Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291970: Add TableStatistics get function to ResourceHashtable #9775

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Aug 5, 2022

Add a statistics_calculate function to ResourceHashtable so that we can use it for printing. Also add a test.
Tested with tier1 on Oracle platforms (with and without product build).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291970: Add TableStatistics get function to ResourceHashtable

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9775/head:pull/9775
$ git checkout pull/9775

Update a local copy of the PR:
$ git checkout pull/9775
$ git pull https://git.openjdk.org/jdk pull/9775/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9775

View PR using the GUI difftool:
$ git pr show -t 9775

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9775.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2022

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 5, 2022
@openjdk
Copy link

openjdk bot commented Aug 5, 2022

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 5, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 5, 2022

Webrevs

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think the test can be simplified by using ResourceHashtable<int, TestValue> so you don't need to explicitly delete the values.

@openjdk
Copy link

openjdk bot commented Aug 8, 2022

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291970: Add TableStatistics get function to ResourceHashtable

Reviewed-by: iklam, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 7739843: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent
  • eb8b789: 8292061: ProblemList serviceability/attach/ConcAttachTest.java on linux-all
  • 08274e6: 8290975: Minor cleanup could be done in javax.security
  • 7db5abd: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
  • 124fc4a: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version
  • 4591937: 8290357: Drop HeapRegion::marked_bytes()
  • 7676be8: 8291037: Move PLAB resizing mechanism to G1EvacStats
  • 861cc67: 8291897: TerminatingThreadLocal(s) not registered from virtual thread(s)
  • 8d88be2: 8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)
  • 8a804f6: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk
  • ... and 14 more: https://git.openjdk.org/jdk/compare/0da4314e95f380f6125120797ad57529f5442cda...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 8, 2022
@coleenp
Copy link
Contributor Author

coleenp commented Aug 8, 2022

I wanted to show the printer lambda getting the literal size of the value, so needed to make it a pointer.
Thanks for reviewing.

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@coleenp
Copy link
Contributor Author

coleenp commented Aug 9, 2022

Thanks Calvin!
/integrate

@openjdk
Copy link

openjdk bot commented Aug 9, 2022

Going to push as commit f5b3618.
Since your change was applied there have been 27 commits pushed to the master branch:

  • cbc9040: 8290278: JavaDoc of index parameter of method JTabbedPane.insertTab
  • 2712bc3: 8289741: Remove unused imports from DTDBuilder.java
  • af243ca: 8265433: IGV: add graph tooltips with properties
  • 7739843: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent
  • eb8b789: 8292061: ProblemList serviceability/attach/ConcAttachTest.java on linux-all
  • 08274e6: 8290975: Minor cleanup could be done in javax.security
  • 7db5abd: 8282642: vmTestbase/gc/gctests/LoadUnloadGC2/LoadUnloadGC2.java fails intermittently with exit code 1
  • 124fc4a: 8290180: Convert com/sun/management/UnixOperatingSystemMXBean/GetOpenFileDescriptorCount.sh to jtreg java version
  • 4591937: 8290357: Drop HeapRegion::marked_bytes()
  • 7676be8: 8291037: Move PLAB resizing mechanism to G1EvacStats
  • ... and 17 more: https://git.openjdk.org/jdk/compare/0da4314e95f380f6125120797ad57529f5442cda...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 9, 2022
@openjdk openjdk bot closed this Aug 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 9, 2022
@openjdk
Copy link

openjdk bot commented Aug 9, 2022

@coleenp Pushed as commit f5b3618.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the tabletest branch August 9, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants