Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291990: [REDO] ProblemList multiple tests in -Xcomp mode due to JDK-8291649 #9785

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Aug 5, 2022

A trivial fix to ProblemList multiple tests in -Xcomp mode due to JDK-8291649.
This time I'll add them to the right ProblemList-Xcomp.txt file.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291990: [REDO] ProblemList multiple tests in -Xcomp mode due to JDK-8291649

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9785/head:pull/9785
$ git checkout pull/9785

Update a local copy of the PR:
$ git checkout pull/9785
$ git pull https://git.openjdk.org/jdk pull/9785/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9785

View PR using the GUI difftool:
$ git pr show -t 9785

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9785.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-compiler

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review August 5, 2022 21:20
@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Aug 5, 2022
@openjdk
Copy link

openjdk bot commented Aug 5, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 5, 2022
@openjdk
Copy link

openjdk bot commented Aug 5, 2022

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@dcubed-ojdk dcubed-ojdk changed the title 8291990: ProblemList multiple tests in -Xcomp mode due to JDK-8291649 8291990: [REDO] ProblemList multiple tests in -Xcomp mode due to JDK-8291649 Aug 5, 2022
@dcubed-ojdk
Copy link
Member Author

@bplb - Thanks for the fast review!

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8291990

@dcubed-ojdk
Copy link
Member Author

/integrate auto

@openjdk
Copy link

openjdk bot commented Aug 5, 2022

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Aug 5, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291990: [REDO] ProblemList multiple tests in -Xcomp mode due to JDK-8291649

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 5, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 5, 2022

Webrevs

@openjdk openjdk bot added the auto label Aug 5, 2022
@openjdk
Copy link

openjdk bot commented Aug 5, 2022

@dcubed-ojdk This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Aug 5, 2022

/integrate

1 similar comment
@openjdk
Copy link

openjdk bot commented Aug 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 5, 2022

Going to push as commit 9bff3b7.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 5, 2022
@openjdk openjdk bot closed this Aug 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 5, 2022
@openjdk
Copy link

openjdk bot commented Aug 5, 2022

@openjdk[bot] Pushed as commit 9bff3b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Aug 5, 2022

@openjdk[bot] The command integrate can only be used in open pull requests.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8291990 branch August 5, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants