Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292119: ProblemList java/awt/image/multiresolution/MultiresolutionIconTest.java on linux-x64 and windows-all #9811

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Aug 9, 2022

A trivial fix to ProblemList java/awt/image/multiresolution/MultiresolutionIconTest.java
on linux-x64 and windows-all


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292119: ProblemList java/awt/image/multiresolution/MultiresolutionIconTest.java on linux-x64 and windows-all

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9811/head:pull/9811
$ git checkout pull/9811

Update a local copy of the PR:
$ git checkout pull/9811
$ git pull https://git.openjdk.org/jdk pull/9811/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9811

View PR using the GUI difftool:
$ git pr show -t 9811

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9811.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add client

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review August 9, 2022 17:35
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 9, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292119: ProblemList java/awt/image/multiresolution/MultiresolutionIconTest.java on linux-x64 and windows-all

Reviewed-by: naoto, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d889264: 8290836: Improve test coverage for XPath functions: String Functions
  • ae1a9a0: 8292060: Make ClassFileVersionTest.java version adapting

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Aug 9, 2022
@openjdk
Copy link

openjdk bot commented Aug 9, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Aug 9, 2022
@openjdk
Copy link

openjdk bot commented Aug 9, 2022

@dcubed-ojdk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Aug 9, 2022

Webrevs

@prrace
Copy link
Contributor

prrace commented Aug 9, 2022

was it problem listed on windows before ?

@prrace
Copy link
Contributor

prrace commented Aug 9, 2022

ah yes it was

@dcubed-ojdk
Copy link
Member Author

@naotoj and @prrace - Thanks for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 9, 2022

Going to push as commit 17c77b5.
Since your change was applied there have been 2 commits pushed to the master branch:

  • d889264: 8290836: Improve test coverage for XPath functions: String Functions
  • ae1a9a0: 8292060: Make ClassFileVersionTest.java version adapting

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 9, 2022
@openjdk openjdk bot closed this Aug 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 9, 2022
@openjdk
Copy link

openjdk bot commented Aug 9, 2022

@dcubed-ojdk Pushed as commit 17c77b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8292119 branch August 9, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants