8292350: Use static methods for hashCode/toString primitives

[turbanoff]

It's a bit shorter and clearer.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292350: Use static methods for hashCode/toString primitives

Reviewers

• Phil Race (@prrace - Reviewer)
• Roger Riggs (@RogerRiggs - Reviewer)
• Alex Menkov (@alexmenkov - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9816/head:pull/9816
$ git checkout pull/9816

Update a local copy of the PR:
$ git checkout pull/9816
$ git pull https://git.openjdk.org/jdk pull/9816/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9816

View PR using the GUI difftool:
$ git pr show -t 9816

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9816.diff

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following labels will be automatically applied to this pull request:

• client
• core-libs
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[ExE-Boss]

Also, it avoids unnecessary boxing.

[mlbridge]

Webrevs

• 00: Full (bd198e71)

[prrace]

Approving (just) the client change

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292350: Use static methods for hashCode/toString primitives

Reviewed-by: prr, rriggs, amenkov, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 117 new commits pushed to the master branch:

• 4453200: 8292628: x86: Improve handling of constants in trigonometric stubs
• 07c9ba7: 8292686: runtime/cds/appcds/TestWithProfiler.java SIGSEGV in TableStatistics ctr
• 235151e: 8292676: Remove two kerberos tests from problem list
• df5209e: 8292683: Remove BadKeyUsageTest.java from Problem List
• 74d3330: 8292682: Code change of JDK-8282730 not updated to reflect CSR update
• 57aac2a: 8290981: Enable CDS for zero builds
• 6a8a531: 8292564: x86: Remove redundant casts in Assembler usages
• 7244dd6: 8292267: Clean up synchronizer.hpp
• 1f3578b: 8292446: Make TableRateStatistics optional in CHT
• 45dec48: 8292592: JFR test TestNative is not reliable due to low rate of sampling.
• ... and 107 more: https://git.openjdk.org/jdk/compare/83dc2e3e45a946dd1302efb84baf3afaa9309ba4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RogerRiggs]

lgtm

[jaikiran]

Looks fine to me.

[turbanoff]

/integrate

[openjdk]

Going to push as commit 37c0a13.
Since your change was applied there have been 117 commits pushed to the master branch:

• 4453200: 8292628: x86: Improve handling of constants in trigonometric stubs
• 07c9ba7: 8292686: runtime/cds/appcds/TestWithProfiler.java SIGSEGV in TableStatistics ctr
• 235151e: 8292676: Remove two kerberos tests from problem list
• df5209e: 8292683: Remove BadKeyUsageTest.java from Problem List
• 74d3330: 8292682: Code change of JDK-8282730 not updated to reflect CSR update
• 57aac2a: 8290981: Enable CDS for zero builds
• 6a8a531: 8292564: x86: Remove redundant casts in Assembler usages
• 7244dd6: 8292267: Clean up synchronizer.hpp
• 1f3578b: 8292446: Make TableRateStatistics optional in CHT
• 45dec48: 8292592: JFR test TestNative is not reliable due to low rate of sampling.
• ... and 107 more: https://git.openjdk.org/jdk/compare/83dc2e3e45a946dd1302efb84baf3afaa9309ba4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit 37c0a13.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.