Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292187: aarch64: Remove duplicate header files #9821

Closed
wants to merge 1 commit into from

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Aug 10, 2022

It's a trivial patch that removes duplicate included header files under hotspot/cpu/aarch64.

aarch64 release and fastdebug build with --disable-precompiled-headers passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9821/head:pull/9821
$ git checkout pull/9821

Update a local copy of the PR:
$ git checkout pull/9821
$ git pull https://git.openjdk.org/jdk pull/9821/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9821

View PR using the GUI difftool:
$ git pr show -t 9821

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9821.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 10, 2022

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 10, 2022
@openjdk
Copy link

openjdk bot commented Aug 10, 2022

@feilongjiang The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 10, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 10, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 10, 2022

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292187: aarch64: Remove duplicate header files

Reviewed-by: aph, ngasson

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 36ef4c1: 8291081: Some sun/tools/jstatd/TestJstatd* tests fail with "Not a percentage: 68.31: expected true, was false"
  • b47438c: 8292068: Convert ModuleEntryTable into ResourceHashtable
  • 543163a: 8291978: jpackage: allow to override primary l10n files on Windows
  • 68af7c1: 8291734: Return accurate ACC_SUPER access flag for classes
  • e4925a3: 8291924: jpackage: l10n for Windows context menu label
  • 7b029ea: 8227651: Tests fail with SSLProtocolException: Input record too big
  • 35fd5d8: 8292200: Add java/io/File/GetXSpace.java to Windows problem list
  • 9825c33: 8291641: Optimize StackTraceElement.toString()
  • cb37282: 8291752: AArch64: Remove check_emit_size parameter from trampoline_call
  • 37d3146: 8289002: Minimal x86_64 VM build fails with GCC 11: 'this' pointer is null
  • ... and 1 more: https://git.openjdk.org/jdk/compare/83dc2e3e45a946dd1302efb84baf3afaa9309ba4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph, @nick-arm) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 10, 2022
@feilongjiang
Copy link
Member Author

@theRealAph @nick-arm -- Thanks!
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 11, 2022
@openjdk
Copy link

openjdk bot commented Aug 11, 2022

@feilongjiang
Your change (at version d14cff1) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 11, 2022

Going to push as commit 2e0a17c.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 36ef4c1: 8291081: Some sun/tools/jstatd/TestJstatd* tests fail with "Not a percentage: 68.31: expected true, was false"
  • b47438c: 8292068: Convert ModuleEntryTable into ResourceHashtable
  • 543163a: 8291978: jpackage: allow to override primary l10n files on Windows
  • 68af7c1: 8291734: Return accurate ACC_SUPER access flag for classes
  • e4925a3: 8291924: jpackage: l10n for Windows context menu label
  • 7b029ea: 8227651: Tests fail with SSLProtocolException: Input record too big
  • 35fd5d8: 8292200: Add java/io/File/GetXSpace.java to Windows problem list
  • 9825c33: 8291641: Optimize StackTraceElement.toString()
  • cb37282: 8291752: AArch64: Remove check_emit_size parameter from trampoline_call
  • 37d3146: 8289002: Minimal x86_64 VM build fails with GCC 11: 'this' pointer is null
  • ... and 1 more: https://git.openjdk.org/jdk/compare/83dc2e3e45a946dd1302efb84baf3afaa9309ba4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 11, 2022
@openjdk openjdk bot closed this Aug 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 11, 2022
@openjdk
Copy link

openjdk bot commented Aug 11, 2022

@RealFYang @feilongjiang Pushed as commit 2e0a17c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@feilongjiang feilongjiang deleted the remove-duplicate branch August 11, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
4 participants