Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284313: Improve warning messages when CDS archive fails to load #9823

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Aug 10, 2022

Please review this change for adding more helpful messages when a CDS archive has failed to load without CDS logging being enabled.

e.g. warning for mismatch class paths between dump time and run time:
[warning][cds] shared class paths mismatch (hint: enable -Xlog:class+path=info to diagnose the failure)

warning if a timestamp of a jar file has been changed during run time:
[warning][cds] app.jar timestamp has changed.

Passed mach5 tiers 1,2,3 testing.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284313: Improve warning messages when CDS archive fails to load

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9823/head:pull/9823
$ git checkout pull/9823

Update a local copy of the PR:
$ git checkout pull/9823
$ git pull https://git.openjdk.org/jdk pull/9823/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9823

View PR using the GUI difftool:
$ git pr show -t 9823

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9823.diff

@calvinccheung
Copy link
Member Author

/label add hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 10, 2022

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Aug 10, 2022
@openjdk
Copy link

openjdk bot commented Aug 10, 2022

@calvinccheung
The hotspot-runtime label was successfully added.

@calvinccheung calvinccheung marked this pull request as ready for review August 10, 2022 17:23
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 10, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 10, 2022

Webrevs

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284313: Improve warning messages when CDS archive fails to load

Reviewed-by: iklam, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 12, 2022
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good - thanks. One typo.

@calvinccheung
Copy link
Member Author

Thanks @iklam, @dholmes-ora.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 12, 2022

Going to push as commit 22d6d31.
Since your change was applied there have been 45 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 12, 2022
@openjdk openjdk bot closed this Aug 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 12, 2022
@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@calvinccheung Pushed as commit 22d6d31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the 8284313-improve-CDS-warning-messages branch August 12, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants