Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160" #9856

Closed
wants to merge 7 commits into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Aug 12, 2022

On Windows, suppress failure if the total space indicated by df is less than FileStore::getTotalSpace and the free space indicated by df equals FileStore::getUnallocatedSpace.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9856/head:pull/9856
$ git checkout pull/9856

Update a local copy of the PR:
$ git checkout pull/9856
$ git pull https://git.openjdk.org/jdk pull/9856/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9856

View PR using the GUI difftool:
$ git pr show -t 9856

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9856.diff

@bplb
Copy link
Member Author

bplb commented Aug 12, 2022

Passed on 20 arbitrary nodes and on one where it failed previously due to user disk quotas.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2022

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 12, 2022
@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 12, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2022

Webrevs

@AlanBateman
Copy link
Contributor

AlanBateman commented Aug 15, 2022

This is hard to review. Would it be possible to provide a summary on how the APIs and df behave with quotas?

@bplb
Copy link
Member Author

bplb commented Aug 15, 2022

This is hard to review. Would it be possible to provide a summary on the APIs and df behave with quotas?

We use the Windows API GetDiskFreeSpaceEx wherein it is stated

  • lpFreeBytesAvailableToCaller: If per-user quotas are being used, this value may be less than the total number of free bytes on a disk.
  • lpTotalNumberOfBytes: If per-user quotas are being used, this value may be less than the total number of bytes on a disk.

The df command on the other hand appears to be using something like GetQuotaInformation which fills a structure which accounts for the quota and provides the currently used and maximum allowed number of bytes for a user.

@bplb
Copy link
Member Author

bplb commented Aug 15, 2022

In reality GetFreeDiskSpaceEx does not appear to recognize the quotas, at least in our tests.

@bplb
Copy link
Member Author

bplb commented Aug 17, 2022

The version of the test in commit 991dc9a passed 5 repeats on Linux and macOS and 51 repeats on Windows, including on a node on which it previously failed.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2022

@bplb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bplb
Copy link
Member Author

bplb commented Sep 15, 2022

continue;

@bplb
Copy link
Member Author

bplb commented Oct 11, 2022

Commit 8129630 passed 50 repeats on the Unix platforms and 150 on Windows.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2022

@bplb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bplb
Copy link
Member Author

bplb commented Nov 9, 2022

Ping.

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 102b2b3: 8292033: Move jdk.X509Certificate event logic to JCA layer
  • 1b94ae1: 8296139: Make GrowableBitMap the base class of all implementations
  • cc8bf95: 8296718: Refactor bootstrap Test Common Functionalities to test/lib/Utils
  • 17e3412: 8296615: use of undeclared identifier 'IPV6_DONTFRAG'
  • a5d838c: 8296591: Signature benchmark
  • fa8a866: 8296675: Exclude linux-aarch64 in NSS tests
  • d4376f8: 8296406: ChainingConstructors jtreg test reduce code duplication
  • 4a0093c: 8294362: UL: Replace the internal usage of manual buffers with stringStream in LogSelection
  • fef68bb: 8296515: RISC-V: Small refactoring for MaxReductionV/MinReductionV/AddReductionV node implementation
  • 82cbfb5: 8296140: Drop unused field java.util.Calendar.DATE_MASK
  • ... and 7 more: https://git.openjdk.org/jdk/compare/dd5d4df5b68a40923987841a206fac5032d72f71...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 9, 2022
@bplb
Copy link
Member Author

bplb commented Nov 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 14, 2022

Going to push as commit 749335d.
Since your change was applied there have been 66 commits pushed to the master branch:

  • 95b8405: 8296431: PushbackInputStream should override transferTo
  • e269dc0: 8293681: ResponseAPDU getData() method javadoc
  • 8c472e4: 8294217: Assertion failure: parsing found no loops but there are some
  • 0fe2bf5: 8296805: ctw build is broken
  • e1d298c: 8296741: Illegal X400Address and EDIPartyName should not be created
  • b0edfc1: 8164464: Consistent failure of java/awt/dnd/MissingEventsOnModalDialog/MissingEventsOnModalDialogTest.java
  • 9c39932: 8294899: Process.waitFor() throws IllegalThreadStateException when a process on Windows returns an exit code of 259
  • 3f401b3: 8296670: G1: Remove unused G1GCPhaseTimes::record_preserve_cm_referents_time_ms
  • 68301cd: 8296665: IGV: Show dialog with stack trace for exceptions
  • 277f0c2: 8296821: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java fails after JDK-8262901
  • ... and 56 more: https://git.openjdk.org/jdk/compare/dd5d4df5b68a40923987841a206fac5032d72f71...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2022
@openjdk openjdk bot closed this Nov 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 14, 2022
@openjdk
Copy link

openjdk bot commented Nov 14, 2022

@bplb Pushed as commit 749335d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the File-GetXSpace-8291911 branch November 14, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants