Skip to content

Conversation

@sormuras
Copy link
Member

@sormuras sormuras commented Aug 12, 2022

Enhance JAXPPolicyManager to setup required permissions for jtreg 7 by accept version information in JAR file names.

Find details in https://bugs.openjdk.org/browse/JDK-8292182


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9857/head:pull/9857
$ git checkout pull/9857

Update a local copy of the PR:
$ git checkout pull/9857
$ git pull https://git.openjdk.org/jdk pull/9857/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9857

View PR using the GUI difftool:
$ git pr show -t 9857

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9857.diff

…sions for jtreg version 7 jar

Accept version information in JAR file names
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2022

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 12, 2022
@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@sormuras The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 12, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2022

Webrevs

Copy link
Member

@JoeWang-Java JoeWang-Java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making it to work with jtreg 7!

@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar

Reviewed-by: joehw, lancea, iris, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 695bb39: 8292347: Remove unused Type::is_ptr_to_boxing_obj
  • ec96b1f: 8290291: G1: Merge multiple calls of block_size in HeapRegion::block_start
  • fd4b2f2: 8291718: Remove mark_for_deoptimization from klass unloading
  • 9d7c13e: 8155246: Throw error if default java.security file is missing
  • e89abb7: 8292190: [IR Framework] Remove redundant regex matching for failing counts constraints
  • 77cd917: Merge
  • 967a28c: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
  • 1c1c441: 8292072: NMT: repurpose Tracking overhead counter as global malloc counter
  • d546d13: 8292319: ProblemList 2 runtime/cds/appcds tests due to JDK-8292313
  • 8353a33: 8286313: [macos] Voice over reads the boolean value as null in the JTable
  • ... and 2 more: https://git.openjdk.org/jdk/compare/00decca46a77ea9390081655b069008aacfea525...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JoeWang-Java, @LanceAndersen, @irisclark, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 12, 2022
Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sormuras
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 13, 2022
@openjdk
Copy link

openjdk bot commented Aug 13, 2022

@sormuras
Your change (at version a9a690a) is now ready to be sponsored by a Committer.

@LanceAndersen
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 15, 2022

Going to push as commit aa5b718.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 695bb39: 8292347: Remove unused Type::is_ptr_to_boxing_obj
  • ec96b1f: 8290291: G1: Merge multiple calls of block_size in HeapRegion::block_start
  • fd4b2f2: 8291718: Remove mark_for_deoptimization from klass unloading
  • 9d7c13e: 8155246: Throw error if default java.security file is missing
  • e89abb7: 8292190: [IR Framework] Remove redundant regex matching for failing counts constraints
  • 77cd917: Merge
  • 967a28c: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
  • 1c1c441: 8292072: NMT: repurpose Tracking overhead counter as global malloc counter
  • d546d13: 8292319: ProblemList 2 runtime/cds/appcds tests due to JDK-8292313
  • 8353a33: 8286313: [macos] Voice over reads the boolean value as null in the JTable
  • ... and 2 more: https://git.openjdk.org/jdk/compare/00decca46a77ea9390081655b069008aacfea525...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 15, 2022
@openjdk openjdk bot closed this Aug 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 15, 2022
@openjdk
Copy link

openjdk bot commented Aug 15, 2022

@LanceAndersen @sormuras Pushed as commit aa5b718.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras sormuras deleted the JDK-8292182-jaxp-policy-manager branch August 15, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

6 participants