-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar #9857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sions for jtreg version 7 jar Accept version information in JAR file names
|
👋 Welcome back cstein! A progress list of the required criteria for merging this PR into |
Webrevs
|
JoeWang-Java
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making it to work with jtreg 7!
|
@sormuras This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JoeWang-Java, @LanceAndersen, @irisclark, @naotoj) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
naotoj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test/jaxp/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java
Outdated
Show resolved
Hide resolved
|
/integrate |
|
/sponsor |
|
Going to push as commit aa5b718.
Your commit was automatically rebased without conflicts. |
|
@LanceAndersen @sormuras Pushed as commit aa5b718. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Enhance
JAXPPolicyManagerto setup required permissions forjtreg7 by accept version information in JAR file names.Find details in https://bugs.openjdk.org/browse/JDK-8292182
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9857/head:pull/9857$ git checkout pull/9857Update a local copy of the PR:
$ git checkout pull/9857$ git pull https://git.openjdk.org/jdk pull/9857/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 9857View PR using the GUI difftool:
$ git pr show -t 9857Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9857.diff