Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292196: Reduce runtime of java.util.regex microbenchmarks #9861

Closed
wants to merge 1 commit into from

Conversation

ericcaspole
Copy link

@ericcaspole ericcaspole commented Aug 12, 2022

These changes reduce the run time to 45 minutes from about 1h40m with stability good enough for weekly promo build testing.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292196: Reduce runtime of java.util.regex microbenchmarks

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9861/head:pull/9861
$ git checkout pull/9861

Update a local copy of the PR:
$ git checkout pull/9861
$ git pull https://git.openjdk.org/jdk pull/9861/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9861

View PR using the GUI difftool:
$ git pr show -t 9861

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9861.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2022

👋 Welcome back ecaspole! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 12, 2022
@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@ericcaspole The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 12, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 15, 2022

@ericcaspole This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292196: Reduce runtime of java.util.regex microbenchmarks

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

  • dd2034b: 8291972: Fix double copy of arguments when thawing two interpreted frames
  • aa5b718: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
  • 695bb39: 8292347: Remove unused Type::is_ptr_to_boxing_obj
  • ec96b1f: 8290291: G1: Merge multiple calls of block_size in HeapRegion::block_start
  • fd4b2f2: 8291718: Remove mark_for_deoptimization from klass unloading
  • 9d7c13e: 8155246: Throw error if default java.security file is missing
  • e89abb7: 8292190: [IR Framework] Remove redundant regex matching for failing counts constraints
  • 77cd917: Merge
  • 967a28c: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large
  • 1c1c441: 8292072: NMT: repurpose Tracking overhead counter as global malloc counter
  • ... and 59 more: https://git.openjdk.org/jdk/compare/08274e6fea982e71ccc5964f4919c65501b048e1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 15, 2022
@ericcaspole
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 15, 2022

Going to push as commit b5707b0.
Since your change was applied there have been 71 commits pushed to the master branch:

  • b00eede: 8291511: Redefinition of EXIT_FAILURE in libw2k_lsa_auth
  • 3a09077: 8291337: Reduce runtime of vm.lamdba microbenchmarks
  • dd2034b: 8291972: Fix double copy of arguments when thawing two interpreted frames
  • aa5b718: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
  • 695bb39: 8292347: Remove unused Type::is_ptr_to_boxing_obj
  • ec96b1f: 8290291: G1: Merge multiple calls of block_size in HeapRegion::block_start
  • fd4b2f2: 8291718: Remove mark_for_deoptimization from klass unloading
  • 9d7c13e: 8155246: Throw error if default java.security file is missing
  • e89abb7: 8292190: [IR Framework] Remove redundant regex matching for failing counts constraints
  • 77cd917: Merge
  • ... and 61 more: https://git.openjdk.org/jdk/compare/08274e6fea982e71ccc5964f4919c65501b048e1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 15, 2022
@openjdk openjdk bot closed this Aug 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 15, 2022
@openjdk
Copy link

openjdk bot commented Aug 15, 2022

@ericcaspole Pushed as commit b5707b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants