Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289616: Drop use of Thread.stop in AppContext #9863

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Aug 12, 2022

Thread.stop() and ThreadGroup.destroy() are called by sun.awt.AppContext.dispose()

These should no longer be called. Both are deprecated for removal.
ThreadGroup.destroy() does nothing. Thread.stop() throws UnsupportedOperationException
for virtual threads, and is expected to do so for all threads if it is not removed before then.

This fix stops calling these methods and prints a warning from dispose() to encourage
callers to move away from AppContext which itself will likely be removed in a future release
since the Webstart and Plugin scenarios that needed it are no longer supported.
Although most tests that use AppContext are now irrelevant only one test actually fails
and is removed so we are doing the least here and the big job of completely getting rid of
AppContext is for another day.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9863/head:pull/9863
$ git checkout pull/9863

Update a local copy of the PR:
$ git checkout pull/9863
$ git pull https://git.openjdk.org/jdk pull/9863/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9863

View PR using the GUI difftool:
$ git pr show -t 9863

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9863.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2022

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8289616 8289616: Drop use of Thread.stop in AppContext Aug 12, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 12, 2022
@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Aug 12, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2022

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. The changes look reasonable to me and the warning will help catch any attempts to use it in the JDK.

@openjdk
Copy link

openjdk bot commented Aug 13, 2022

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289616: Drop use of Thread.stop in AppContext

Reviewed-by: alanb, iris, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 13, 2022
Additionally AppContext will be removed in a future release.
Remove all uses of this internal class as soon as possible.
There is no replacement.
""");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should some portion of this warning be included in an @implNote in this method's JavaDoc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is internal API I think that unnecessarily generous.
It shouldn't be called anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in time it can be removed, which removes the temptation to use it completely.

@prrace
Copy link
Contributor Author

prrace commented Aug 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2022

Going to push as commit 01b87ba.
Since your change was applied there have been 35 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2022
@openjdk openjdk bot closed this Aug 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2022
@openjdk
Copy link

openjdk bot commented Aug 16, 2022

@prrace Pushed as commit 01b87ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants