Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292305: [BACKOUT] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS #9864

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Aug 12, 2022

This reverts commit 00decca.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292305: [BACKOUT] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9864/head:pull/9864
$ git checkout pull/9864

Update a local copy of the PR:
$ git checkout pull/9864
$ git pull https://git.openjdk.org/jdk pull/9864/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9864

View PR using the GUI difftool:
$ git pr show -t 9864

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9864.diff

….java occasionally crashes on MacOS

This reverts commit 00decca.
@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add client

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review August 12, 2022 20:30
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Aug 12, 2022
@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Aug 12, 2022
@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@dcubed-ojdk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Aug 12, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292305: [BACKOUT] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS

Reviewed-by: prr, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 12, 2022
@dcubed-ojdk
Copy link
Member Author

@prrace - Thanks for the fast review.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backout looks accurate

@dcubed-ojdk
Copy link
Member Author

@dholmes-ora - Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 12, 2022

Going to push as commit e70747b.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 12, 2022
@openjdk openjdk bot closed this Aug 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 12, 2022
@openjdk
Copy link

openjdk bot commented Aug 12, 2022

@dcubed-ojdk Pushed as commit e70747b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8292305 branch October 26, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants