8292309 : Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test

[lawrence-andrew]

1. Fixed Parse Exception by removing yesno
   test result: Error. Parse Exception: Arguments to `manual' option not supported: yesno
2. Throw jtreg.SkippedException when printer is not configured on the test host
3. Replaced Sysout & TestDialog with ManualTestFrame, which allows to the user to better decide test results and to take screen shot if test fails.

@shurymury

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test

Reviewers

• Jayathirth D V (@jayathirthrao - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9865/head:pull/9865
$ git checkout pull/9865

Update a local copy of the PR:
$ git checkout pull/9865
$ git pull https://git.openjdk.org/jdk pull/9865/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9865

View PR using the GUI difftool:
$ git pr show -t 9865

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9865.diff

[bridgekeeper]

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lawrence-andrew The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (f9e40ce1)
• 01: Full - Incremental (07495189)
• 00: Full (aea79929)

[shurymury]

LGTM

[mrserb]

I still not sure about the case when we start to throw the "SkippedException" if the printer is not found and the "printer" keyword is set, especially for the manual test case. Is it expected that the user will run the "printer" related test and it will pass automcatically, how we will force to actually run the test in proper envirement?

[lawrence-andrew]

Removed @key printer since its a label on the test that used to filter the test & since its a manual test we dn't need the label. We can use SkippedException if printer on available we can throw the exception.

[jayathirthrao]

Looks like concern related to jtreg.SkippedException and its probably solution captured at : #8412 (comment)

Since updated test follows https://openjdk.org/jtreg/faq.html#what-if-a-test-does-not-apply-in-a-given-situation and test is able to run in an environment where printer is configured. And throws SkippedException with appropriate message when printer is not configured, change looks okay to me.

But as captured at #8412 (comment), we may need to update PassFailJFrame to handle these manual test case scenarios and show UI message that test is not run because of bad environment.

[openjdk]

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292309: Fix java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java test

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 613 new commits pushed to the master branch:

• 3644e26: 8294673: JFR: Add SecurityProviderService#threshold to TestActiveSettingEvent.java
• 085949a: 8294712: G1: Use index-base iteration for G1FlushHumongousCandidateRemSets
• b850f05: 8294758: JFR: Docs build fails after changes to RecordedObject and Timespan
• 2dbedf0: 8294406: Test runtime/handshake/HandshakeDirectTest.java failed: JVMTI_ERROR_WRONG_PHASE
• 4d6668e: 8294242: JFR: jfr print doesn't handle infinite duration well
• 5a9cd33: 8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport
• f03934e: 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode
• 3b476a1: 8292847: Zero: Allow ergonomics to select the GC
• 16047e8: 8292780: misc tests failed "assert(false) failed: graph should be schedulable"
• bf39b18: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces
• ... and 603 more: https://git.openjdk.org/jdk/compare/e70747b4e9bd9c161b95c88ff0d58609f0b08d42...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jayathirthrao) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[lawrence-andrew]

/integrate

[openjdk]

@lawrence-andrew
Your change (at version f9e40ce) is now ready to be sponsored by a Committer.

[jayathirthrao]

/sponsor

[openjdk]

Going to push as commit b22a38d.
Since your change was applied there have been 615 commits pushed to the master branch:

• 121d4a5: 8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform
• 1166a8a: 8292214: Memory leak in getAllConfigs of awt_GraphicsEnv.c:386
• 3644e26: 8294673: JFR: Add SecurityProviderService#threshold to TestActiveSettingEvent.java
• 085949a: 8294712: G1: Use index-base iteration for G1FlushHumongousCandidateRemSets
• b850f05: 8294758: JFR: Docs build fails after changes to RecordedObject and Timespan
• 2dbedf0: 8294406: Test runtime/handshake/HandshakeDirectTest.java failed: JVMTI_ERROR_WRONG_PHASE
• 4d6668e: 8294242: JFR: jfr print doesn't handle infinite duration well
• 5a9cd33: 8294509: The sign extension bug applies to 'public static int[] convertSeedBytesToInts(byte[] seed, int n, int z)' in RandomSupport
• f03934e: 8294578: [PPC64] C2: Missing is_oop information when using disjoint compressed oops mode
• 3b476a1: 8292847: Zero: Allow ergonomics to select the GC
• ... and 605 more: https://git.openjdk.org/jdk/compare/e70747b4e9bd9c161b95c88ff0d58609f0b08d42...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jayathirthrao @lawrence-andrew Pushed as commit b22a38d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.