8292304: [REDO] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS

[mkartashev]

See also the original pull request where the change is explained and discussed in details.

Compared to the original version of this fix I

• changed the error reporting from printStackTrace() to System.out.println() as per @prrace request,
• fixed the test to use AtomicInteger for the counter of disposer records as += and -- operations on a volatile int do not guarantee value's integrity, which caused the test to often fail.

test/jdk/sun/java2d/Disposer/TestDisposerRace.java now passes successfully on MacOS and Linux.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292304: [REDO] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS

Reviewers

• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9890/head:pull/9890
$ git checkout pull/9890

Update a local copy of the PR:
$ git checkout pull/9890
$ git pull https://git.openjdk.org/jdk pull/9890/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9890

View PR using the GUI difftool:
$ git pr show -t 9890

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9890.diff

[bridgekeeper]

👋 Welcome back mkartashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mkartashev The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d289bee0)

[prrace]

I ran this and the new tests with all our other tests and the job passed so this looks fine now.
Still, I suggest to wait for Monday before pushing :-)

[openjdk]

@mkartashev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292304: [REDO] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 124 new commits pushed to the master branch:

• 5a20bc4: 8292715: Cleanup Problemlist
• 7b81a9c: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
• 76ee549: 8292329: Enable CDS shared heap for zero builds
• 14623c6: 8292739: Invalid legacy entries may be returned by Provider.getServices() call
• 568be58: 8290469: Add new positioning options to PassFailJFrame test framework
• 69448f9: 8292679: Simplify thread creation in gtest and port 2 tests to new way
• 3c2289d: 8215916: The failure reason of an optional JAAS LoginModule is not logged
• 71ab5c9: 8292816: GPL Classpath exception missing from assemblyprefix.h
• c062397: 8292713: Unsafe.allocateInstance should be intrinsified without UseUnalignedAccesses
• a45a4b9: 8292194: G1 nmethod entry barrier disarm value wraps around too early
• ... and 114 more: https://git.openjdk.org/jdk/compare/3a090777bada2e00f573fe8ab113bfa3884982eb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[avu]

/sponsor

[openjdk]

@avu The change author (@mkartashev) must issue an integrate command before the integration can be sponsored.

[mkartashev]

/integrate

[openjdk]

@mkartashev
Your change (at version d289bee) is now ready to be sponsored by a Committer.

[prrace]

/sponsor

[openjdk]

Going to push as commit 5d799d8.
Since your change was applied there have been 132 commits pushed to the master branch:

• 4f50316: 8292680: Convert Dictionary to ConcurrentHashTable
• 2fe0ce0: 8292203: AArch64: Represent Registers as values
• 251bff6: 8292877: java/util/concurrent/atomic/Serial.java uses {Double,Long}Accumulator incorrectly
• f57d342: 8292867: RISC-V: Simplify weak CAS return value handling
• 88af204: 8292494: Ensure SystemDictionary::set_platform_loader and set_system_loader are called only once
• 8d3d439: 8292903: enhance round_up_power_of_2 assertion output
• 054c23f: 8290025: Remove the Sweeper
• dc7e256: 8290376: G1: Refactor G1MMUTracker::when_sec
• 5a20bc4: 8292715: Cleanup Problemlist
• 7b81a9c: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
• ... and 122 more: https://git.openjdk.org/jdk/compare/3a090777bada2e00f573fe8ab113bfa3884982eb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace @mkartashev Pushed as commit 5d799d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.