Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292509: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java on windows #9894

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Aug 16, 2022

Trivial fixes to ProblemList two different tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8292509: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java on windows
  • JDK-8292510: ProblemList runtime/cds/appcds/cacheObject/ArchivedEnumTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9894/head:pull/9894
$ git checkout pull/9894

Update a local copy of the PR:
$ git checkout pull/9894
$ git pull https://git.openjdk.org/jdk pull/9894/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9894

View PR using the GUI difftool:
$ git pr show -t 9894

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9894.diff

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8292509
/issue JDK-8292510

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add core-libs

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review August 16, 2022 22:45
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Jdk 8292509 8292509: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java on windows Aug 16, 2022
@openjdk
Copy link

openjdk bot commented Aug 16, 2022

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@dcubed-ojdk
Copy link
Member Author

@jddarcy - Thanks for the fast review. I'm now waiting for the bots to catch up...

@openjdk
Copy link

openjdk bot commented Aug 16, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292509: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java on windows
8292510: ProblemList runtime/cds/appcds/cacheObject/ArchivedEnumTest.java

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 01b87ba: 8289616: Drop use of Thread.stop in AppContext

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2022
@openjdk
Copy link

openjdk bot commented Aug 16, 2022

@dcubed-ojdk
Adding additional issue to issue list: 8292510: ProblemList runtime/cds/appcds/cacheObject/ArchivedEnumTest.java.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Aug 16, 2022
@openjdk
Copy link

openjdk bot commented Aug 16, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 16, 2022
@openjdk
Copy link

openjdk bot commented Aug 16, 2022

@dcubed-ojdk
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Aug 16, 2022

Webrevs

@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2022

Going to push as commit da477b1.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 01b87ba: 8289616: Drop use of Thread.stop in AppContext

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2022
@openjdk openjdk bot closed this Aug 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2022
@openjdk
Copy link

openjdk bot commented Aug 16, 2022

@dcubed-ojdk Pushed as commit da477b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8292509 branch August 17, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants