Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292564: x86: Remove redundant casts in Assembler usages #9909

Closed
wants to merge 4 commits into from

Conversation

iwanowww
Copy link
Contributor

@iwanowww iwanowww commented Aug 17, 2022

Clean up Assembler API and remove redundant at use sites.

They are not needed anymore because implicit casts between Register and integrals are forbidden now.

Some of the casts are turned into static_casts to assert that constants are small enough to fit into 32-bit immediate.

Testing: hs-tier1 - hs-tier4


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292564: x86: Remove redundant casts in Assembler usages

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9909/head:pull/9909
$ git checkout pull/9909

Update a local copy of the PR:
$ git checkout pull/9909
$ git pull https://git.openjdk.org/jdk pull/9909/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9909

View PR using the GUI difftool:
$ git pr show -t 9909

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9909.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2022

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@iwanowww
The hotspot label was successfully added.

@iwanowww iwanowww marked this pull request as ready for review August 17, 2022 19:36
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 17, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2022

Webrevs

Copy link
Contributor

@veresov veresov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292564: x86: Remove redundant casts in Assembler usages

Reviewed-by: iveresov, kvn, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 37aa7c1: 8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers
  • f2f0cd8: 8292511: AArch64: Align CPU feature name for NEON with hwcap
  • 1f484da: 8289562: Change bugs.java.com and bugreport.java.com URL's to https
  • 63a126a: 8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable
  • 7d18ebd: 8292606: G1 and Epsilon header cleanup for JDK-8282729
  • 2edd550: 8292312: Work around memset() called operator new
  • 964aac2: 8292499: CDS ArchivedEnumTest.java fails: object points to a static field that may be reinitialized
  • f85411f: 8292458: Atomic operations on scoped enums don't build with clang
  • 82dbe29: 8292633: runtime/cds/appcds/dynamicArchive/CDSStreamTestDriver.java fails to compile
  • 54ce114: 6587699: Document DigestInputStream behavior when skip() or mark() / reset() is used
  • ... and 13 more: https://git.openjdk.org/jdk/compare/e8bc87956abc92851de8694c56a78f6ecc546cbd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 17, 2022
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@shipilev
Copy link
Member

Some of the casts are turned into static_casts to assert that constants are small enough to fit into 32-bit immediate.

This confuses me a bit: I thought narrowing (implicit) conversions with static_cast would not assert safety in these cases. We have checked_cast for these.

@iwanowww
Copy link
Contributor Author

Good catch, Aleksey. I intended to use checked_cast, but misremembered the name. Fixed.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I also tested with Alpine builds, that are known to get funky with intptr_t conversions.

@iwanowww
Copy link
Contributor Author

Thanks for the reviews, Igor, Vladimir, and Aleksey.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

Going to push as commit 6a8a531.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 7244dd6: 8292267: Clean up synchronizer.hpp
  • 1f3578b: 8292446: Make TableRateStatistics optional in CHT
  • 45dec48: 8292592: JFR test TestNative is not reliable due to low rate of sampling.
  • 58aae34: 8292576: Improve wording of AccessFlag-related specs
  • 5ca268c: 8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID
  • 37aa7c1: 8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers
  • f2f0cd8: 8292511: AArch64: Align CPU feature name for NEON with hwcap
  • 1f484da: 8289562: Change bugs.java.com and bugreport.java.com URL's to https
  • 63a126a: 8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable
  • 7d18ebd: 8292606: G1 and Epsilon header cleanup for JDK-8282729
  • ... and 18 more: https://git.openjdk.org/jdk/compare/e8bc87956abc92851de8694c56a78f6ecc546cbd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 19, 2022
@openjdk openjdk bot closed this Aug 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@iwanowww Pushed as commit 6a8a531.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
4 participants