Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8292498: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed with "AssertionError: only show error once expected [1] but found [0]" #9911

Closed
wants to merge 2 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Aug 17, 2022

The use of lambda's in the initialization of AccessFlag runs afoul of CDS in some cases due to occurring early in the platform's initialization. Instead of lambdas, using anonymous classes gets around the issue.

Clean tier1 and tier 2 Mach 5 run with these changes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292498: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed with "AssertionError: only show error once expected [1] but found [0]"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9911/head:pull/9911
$ git checkout pull/9911

Update a local copy of the PR:
$ git checkout pull/9911
$ git pull https://git.openjdk.org/jdk pull/9911/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9911

View PR using the GUI difftool:
$ git pr show -t 9911

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9911.diff

…led with "AssertionError: only show error once expected [1] but found [0]"
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 17, 2022
@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 17, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2022

Webrevs

Copy link
Member

@PaulSandoz PaulSandoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a shame. Code changes look good. I recommend adding an internal comment within the top of the class declaration indicating why anon inner classes are used, esp. since this there is more action at a distance than the usual case where lambdas are used too early in the JDK initialization process.

@openjdk
Copy link

openjdk bot commented Aug 17, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292498: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed with "AssertionError: only show error once expected [1] but found [0]"

Reviewed-by: psandoz, mchung, jpai, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • f2773f6: 8292556: Clean up unused Hashtable instantiations
  • d543564: 8289334: Use CSS variables to define fonts and colors
  • 2ee9491: 8289051: C2: Cleanup PhaseCCP::analyze()
  • 32d675c: 8291775: C2: assert(r != __null && r->is_Region()) failed: this phi must have a region
  • 0d96546: 8292054: Test runtime/posixSig/TestPosixSig.java fails with 'Test failed, bad output.'

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 17, 2022
@RogerRiggs
Copy link
Contributor

This is very unfortunate, the reason to use Lambdas was to avoid creating all the subclasses that would be generated by subclassing the location() method. At least in this form, the subclasses are not initialized until they are used.

@jddarcy
Copy link
Member Author

jddarcy commented Aug 17, 2022

Its a shame. Code changes look good. I recommend adding an internal comment within the top of the class declaration indicating why anon inner classes are used, esp. since this there is more action at a distance than the usual case where lambdas are used too early in the JDK initialization process.

Agree that adding an explanatory comment is a good practice; I thought the same myself shortly after creating the PR :-)

Copy link
Member

@mlchung mlchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed this is unfortunate. The change looks good.

@dfuch
Copy link
Member

dfuch commented Aug 18, 2022

Stupid question: it seems none of these lambdas/anonymous classes capture any parameters, all are stateless, and several seems to be identical. Would it make the code cleaner to use static inner classes?

@RogerRiggs
Copy link
Contributor

Stupid question: it seems none of these lambdas/anonymous classes capture any parameters, all are stateless, and several seems to be identical. Would it make the code cleaner to use static inner classes?

Keeping the source for the function/body close to or nested in the declaration of each enum is very desirable.

@jddarcy
Copy link
Member Author

jddarcy commented Aug 18, 2022

Stupid question: it seems none of these lambdas/anonymous classes capture any parameters, all are stateless, and several seems to be identical. Would it make the code cleaner to use static inner classes?

Keeping the source for the function/body close to or nested in the declaration of each enum is very desirable.

Yes, the enum's method was coded in approximately this way to help with maintenance and readability. If this proves to be troublesome over time, there are harder-to-read/understand refactorings that could be used instead.

@jddarcy
Copy link
Member Author

jddarcy commented Aug 18, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

Going to push as commit f567fa0.
Since your change was applied there have been 6 commits pushed to the master branch:

  • d00e7b9: 8292544: G1: Remove virtual specifier for methods in G1EdenRegions and G1SurvivorRegions
  • f2773f6: 8292556: Clean up unused Hashtable instantiations
  • d543564: 8289334: Use CSS variables to define fonts and colors
  • 2ee9491: 8289051: C2: Cleanup PhaseCCP::analyze()
  • 32d675c: 8291775: C2: assert(r != __null && r->is_Region()) failed: this phi must have a region
  • 0d96546: 8292054: Test runtime/posixSig/TestPosixSig.java fails with 'Test failed, bad output.'

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 18, 2022
@openjdk openjdk bot closed this Aug 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@jddarcy Pushed as commit f567fa0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
6 participants