JDK-8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle

[MBaesken]

NTLMAuthSequence getCredentialsHandle has a number of cleanup paths doing various JNU_ReleaseStringPlatformChars calls; those could be placed at one place in the function.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle

Reviewers

• Michael McMahon (@Michael-Mc-Mahon - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9914/head:pull/9914
$ git checkout pull/9914

Update a local copy of the PR:
$ git checkout pull/9914
$ git pull https://git.openjdk.org/jdk pull/9914/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9914

View PR using the GUI difftool:
$ git pr show -t 9914

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9914.diff

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (bed824de)
• 00: Full (4b6e3e14)

[Michael-Mc-Mahon]

Looks good. Minor suggestion that the check in line 144 be changed to:

if (ss == SEC_E_OK) {

which complements the change to the initialization of variable ss.

[MBaesken]

Looks good. Minor suggestion that the check in line 144 be changed to:

if (ss == SEC_E_OK) {

which complements the change to the initialization of variable ss.

Hi Michael, I adjusted the check.

[Michael-Mc-Mahon]

looks good to me.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle

Reviewed-by: michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• f2773f6: 8292556: Clean up unused Hashtable instantiations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[MBaesken]

/integrate

[openjdk]

Going to push as commit 84936e9.
Since your change was applied there have been 63 commits pushed to the master branch:

• 259ba86: 8290075: [JVMCI] only blessed methods can link against EventWriterFactory.getEventWriter
• a85a723: 8292351: tty should always live
• 4da1745: 8291118: [vectorapi] Optimize the implementation of lanewise FIRST_NONZERO
• 38a8191: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets.
• 27af014: 8292743: Missing include resourceHash.hpp
• f58aaab: 8292262: adjust timeouts in several M&M tests
• ab69885: 8292215: java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java times out with slowdebug
• 54843b7: 8290211: jdk/internal/vm/Continuation/Fuzz.java failed with "AssertionError: Failed to compile int Fuzz.com_int(int,int) in 5000ms"
• 8a0c3e5: 8292261: adjust timeouts in JLI GetObjectSizeIntrinsicsTest.java
• 8e8ee4b: 8292596: Make SymbolHashMap a ResourceHashtable
• ... and 53 more: https://git.openjdk.org/jdk/compare/d5435642f9671766ecbcbf744ecd8e62fb929a69...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 84936e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.