Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292592: JFR test TestNative is not reliable due to low rate of sampling. #9915

Closed
wants to merge 2 commits into from

Conversation

robehn
Copy link
Contributor

@robehn robehn commented Aug 18, 2022

Split TestNative into two different test, so native sampling can have a high frequency.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292592: JFR test TestNative is not reliable due to low rate of sampling.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9915/head:pull/9915
$ git checkout pull/9915

Update a local copy of the PR:
$ git checkout pull/9915
$ git pull https://git.openjdk.org/jdk pull/9915/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9915

View PR using the GUI difftool:
$ git pr show -t 9915

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9915.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2022

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@robehn The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Aug 18, 2022
@robehn robehn marked this pull request as ready for review August 18, 2022 11:51
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 18, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2022

Webrevs

@egahlin
Copy link
Member

egahlin commented Aug 18, 2022

The new test uses jdk.ExecutionSample, not jdk.NativeMethodSample. This might be by design, but I thought I should mention it.

@robehn
Copy link
Contributor Author

robehn commented Aug 18, 2022

The new test uses jdk.ExecutionSample, not jdk.NativeMethodSample. This might be by design, but I thought I should mention it.

Yes, you are correct @egahlin.
If we are to not use a native library we have no reliable methods to call for native sample. (when using so low sample rate)
Since the sampler issue with long sleep should be trigger by either sampled type this was much better IMHO.

@robehn
Copy link
Contributor Author

robehn commented Aug 18, 2022

Thank you @egahlin !

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292592: JFR test TestNative is not reliable due to low rate of sampling.

Reviewed-by: egahlin, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 58aae34: 8292576: Improve wording of AccessFlag-related specs
  • 5ca268c: 8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID
  • 37aa7c1: 8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers
  • f2f0cd8: 8292511: AArch64: Align CPU feature name for NEON with hwcap
  • 1f484da: 8289562: Change bugs.java.com and bugreport.java.com URL's to https
  • 63a126a: 8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable
  • 7d18ebd: 8292606: G1 and Epsilon header cleanup for JDK-8282729
  • 2edd550: 8292312: Work around memset() called operator new
  • 964aac2: 8292499: CDS ArchivedEnumTest.java fails: object points to a static field that may be reinitialized
  • f85411f: 8292458: Atomic operations on scoped enums don't build with clang
  • ... and 14 more: https://git.openjdk.org/jdk/compare/0d96546ab93600f17877e5db2770e4125916bcda...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 18, 2022
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: not sure if all imports are needed, like AtomicInteger?

@robehn
Copy link
Contributor Author

robehn commented Aug 19, 2022

@shipilev thank you! I'll fix that before push!

@robehn
Copy link
Contributor Author

robehn commented Aug 19, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 19, 2022

Going to push as commit 45dec48.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 58aae34: 8292576: Improve wording of AccessFlag-related specs
  • 5ca268c: 8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID
  • 37aa7c1: 8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers
  • f2f0cd8: 8292511: AArch64: Align CPU feature name for NEON with hwcap
  • 1f484da: 8289562: Change bugs.java.com and bugreport.java.com URL's to https
  • 63a126a: 8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable
  • 7d18ebd: 8292606: G1 and Epsilon header cleanup for JDK-8282729
  • 2edd550: 8292312: Work around memset() called operator new
  • 964aac2: 8292499: CDS ArchivedEnumTest.java fails: object points to a static field that may be reinitialized
  • f85411f: 8292458: Atomic operations on scoped enums don't build with clang
  • ... and 14 more: https://git.openjdk.org/jdk/compare/0d96546ab93600f17877e5db2770e4125916bcda...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 19, 2022
@openjdk openjdk bot closed this Aug 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 19, 2022
@openjdk
Copy link

openjdk bot commented Aug 19, 2022

@robehn Pushed as commit 45dec48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@robehn robehn deleted the 8292592 branch September 21, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
3 participants