Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292315: Tests should not rely on specific JAR file names (hotspot) #9916

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Aug 18, 2022

These changes improve test stability by removing a hard-coded dependency on a JAR file name.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292315: Tests should not rely on specific JAR file names (hotspot)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9916/head:pull/9916
$ git checkout pull/9916

Update a local copy of the PR:
$ git checkout pull/9916
$ git pull https://git.openjdk.org/jdk pull/9916/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9916

View PR using the GUI difftool:
$ git pr show -t 9916

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9916.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2022

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@sormuras The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Aug 18, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 18, 2022

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292315: Tests should not rely on specific JAR file names (hotspot)

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f567fa0: 8292498: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed with "AssertionError: only show error once expected [1] but found [0]"
  • d00e7b9: 8292544: G1: Remove virtual specifier for methods in G1EdenRegions and G1SurvivorRegions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@sormuras
Copy link
Member Author

/integrate

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@sormuras
Your change (at version 629e8aa) is now ready to be sponsored by a Committer.

@vicente-romero-oracle
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

Going to push as commit 62a7fc6.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 20a3cb7: 8292488: JFR: Incorrect comment in ActiveRecordingEvent
  • f567fa0: 8292498: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed with "AssertionError: only show error once expected [1] but found [0]"
  • d00e7b9: 8292544: G1: Remove virtual specifier for methods in G1EdenRegions and G1SurvivorRegions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 18, 2022
@openjdk openjdk bot closed this Aug 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@vicente-romero-oracle @sormuras Pushed as commit 62a7fc6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras sormuras deleted the JDK-8292315-find-testng-jar-via-code-source branch August 18, 2022 17:30
@dcubed-ojdk
Copy link
Member

dcubed-ojdk commented Aug 18, 2022

runtime/cds/appcds/dynamicArchive/CDSStreamTestDriver.java fails
to compile in Mach5 Tier2 after this PR. See:

JDK-8292633 runtime/cds/appcds/dynamicArchive/CDSStreamTestDriver.java fails to compile

@dcubed-ojdk
Copy link
Member

This test (runtime/cds/appcds/dynamicArchive/CDSStreamTestDriver.java) does not
execute in Tier1 so if GHA was relied upon to test this fix, then that didn't get the
job done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants