8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers

[hseigel]

Please review this small change to add a test that option -XX:+CheckJNICalls shows changed signal handlers. This new test is a copy of the recently deleted TestPosixSig.java with small changes. This version of the test only checks that handlers were changed for SIGFPE and SIGILL signals.

The test was tested using Mach5 to run it on Linux, Mac OS, and Windows.

Thanks, Harold

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer) ⚠️ Review applies to 0a2e92d5
• Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to 0a2e92d5

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9919/head:pull/9919
$ git checkout pull/9919

Update a local copy of the PR:
$ git checkout pull/9919
$ git pull https://git.openjdk.org/jdk pull/9919/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9919

View PR using the GUI difftool:
$ git pr show -t 9919

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9919.diff

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hseigel The following labels will be automatically applied to this pull request:

• build
• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (6bf8fdec)
• 00: Full (0a2e92d5)

[tstuefe]

LGTM. Thanks for this test.

[tstuefe]

Nit: handler could be file scope static, and does not need extern "C"

[hseigel]

fixed

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292559: Add test for -XX:+CheckJNICalls showing changed signal handlers

Reviewed-by: stuefe, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• f2f0cd8: 8292511: AArch64: Align CPU feature name for NEON with hwcap
• 1f484da: 8289562: Change bugs.java.com and bugreport.java.com URL's to https
• 63a126a: 8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable
• 7d18ebd: 8292606: G1 and Epsilon header cleanup for JDK-8282729
• 2edd550: 8292312: Work around memset() called operator new
• 964aac2: 8292499: CDS ArchivedEnumTest.java fails: object points to a static field that may be reinitialized
• f85411f: 8292458: Atomic operations on scoped enums don't build with clang
• 82dbe29: 8292633: runtime/cds/appcds/dynamicArchive/CDSStreamTestDriver.java fails to compile
• 54ce114: 6587699: Document DigestInputStream behavior when skip() or mark() / reset() is used
• a1df2da: 8292632: compiler/sharedstubs/SharedTrampolineTest.java fails with "Error: VM option 'PrintRelocations' is develop and is available only in debug version of VM."
• ... and 7 more: https://git.openjdk.org/jdk/compare/f2773f6404970481ed960ce132dac01feced2eac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Looks good. Glad the test is revived.

[hseigel]

Thanks Thomas and Coleen for suggesting adding this test and reviewing this PR!

[tstuefe]

Still good.

[magicus]

/label -build

[openjdk]

@magicus
The build label was successfully removed.

[hseigel]

/integrate

[openjdk]

Going to push as commit 37aa7c1.
Since your change was applied there have been 17 commits pushed to the master branch:

• f2f0cd8: 8292511: AArch64: Align CPU feature name for NEON with hwcap
• 1f484da: 8289562: Change bugs.java.com and bugreport.java.com URL's to https
• 63a126a: 8292607: Remove unused dirty and dirty_card_range_after_reset in CardTable
• 7d18ebd: 8292606: G1 and Epsilon header cleanup for JDK-8282729
• 2edd550: 8292312: Work around memset() called operator new
• 964aac2: 8292499: CDS ArchivedEnumTest.java fails: object points to a static field that may be reinitialized
• f85411f: 8292458: Atomic operations on scoped enums don't build with clang
• 82dbe29: 8292633: runtime/cds/appcds/dynamicArchive/CDSStreamTestDriver.java fails to compile
• 54ce114: 6587699: Document DigestInputStream behavior when skip() or mark() / reset() is used
• a1df2da: 8292632: compiler/sharedstubs/SharedTrampolineTest.java fails with "Error: VM option 'PrintRelocations' is develop and is available only in debug version of VM."
• ... and 7 more: https://git.openjdk.org/jdk/compare/f2773f6404970481ed960ce132dac01feced2eac...master

Your commit was automatically rebased without conflicts.

[openjdk]

@hseigel Pushed as commit 37aa7c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.