Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292632: compiler/sharedstubs/SharedTrampolineTest.java fails with "Error: VM option 'PrintRelocations' is develop and is available only in debug version of VM." #9930

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Aug 18, 2022

A trivial fix so that compiler/sharedstubs/SharedTrampolineTest.java requires
debug bits to use the '-XX:PrintRelocations' option.

This failure was reproduced on my M1 MacMini with 'release' bits and I verified
that the test no longer runs with 'release' bits after the fix. I also verified that
the test runs and passes with 'fastdebug' bits.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292632: compiler/sharedstubs/SharedTrampolineTest.java fails with "Error: VM option 'PrintRelocations' is develop and is available only in debug version of VM."

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9930/head:pull/9930
$ git checkout pull/9930

Update a local copy of the PR:
$ git checkout pull/9930
$ git pull https://git.openjdk.org/jdk pull/9930/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9930

View PR using the GUI difftool:
$ git pr show -t 9930

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9930.diff

…rror: VM option 'PrintRelocations' is develop and is available only in debug version of VM."
@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-compiler

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review August 18, 2022 20:56
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial.

Thanks

@dcubed-ojdk
Copy link
Member Author

@dholmes-ora - Thanks for the fast review.

/integrate auto

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292632: compiler/sharedstubs/SharedTrampolineTest.java fails with "Error: VM option 'PrintRelocations' is develop and is available only in debug version of VM."

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 1b756bf: 8236048: Cleanup use of Utils.normalizeNewlines
  • 97e2689: 8288121: [JVMCI] Re-export the TerminatingThreadLocal functionality to the graal compiler.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Aug 18, 2022

Webrevs

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the auto label Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@dcubed-ojdk This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 18, 2022

Going to push as commit a1df2da.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 1b756bf: 8236048: Cleanup use of Utils.normalizeNewlines
  • 97e2689: 8288121: [JVMCI] Re-export the TerminatingThreadLocal functionality to the graal compiler.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 18, 2022
@openjdk openjdk bot closed this Aug 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 18, 2022
@openjdk
Copy link

openjdk bot commented Aug 18, 2022

@openjdk[bot] Pushed as commit a1df2da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8292632 branch August 19, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants