8292656: G1: Remove G1HotCardCache::_use_cache

[albertnetymk]

Simple change of removing an unneeded field. This PR contains two commits:

1. Removing the field and its accessors.
2. Renaming a method.

Test: hotspot_gc

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292656: G1: Remove G1HotCardCache::_use_cache

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9939/head:pull/9939
$ git checkout pull/9939

Update a local copy of the PR:
$ git checkout pull/9939
$ git pull https://git.openjdk.org/jdk pull/9939/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9939

View PR using the GUI difftool:
$ git pr show -t 9939

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9939.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (137a745d)

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292656: G1: Remove G1HotCardCache::_use_cache

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 07c7977: 8290249: Vectorize signum on AArch64
• a3ec0bb: 8253413: [REDO] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
• 27b0f77: 8292318: Memory corruption in remove_dumptime_info
• 9a65524: 8290300: Use standard String-joining tools where applicable
• f9004fe: 8292561: Make "ReplayCompiles" a diagnostic product switch
• 2fbb936: 8292691: Move CompilerConfig::is_xxx() inline functions out of compilerDefinitions.hpp
• 3601e30: 8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN"
• 37c0a13: 8292350: Use static methods for hashCode/toString primitives
• 4453200: 8292628: x86: Improve handling of constants in trigonometric stubs
• 07c9ba7: 8292686: runtime/cds/appcds/TestWithProfiler.java SIGSEGV in TableStatistics ctr
• ... and 11 more: https://git.openjdk.org/jdk/compare/f2f0cd86bf4dce4633f484476077fd090549780e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 476c484.
Since your change was applied there have been 25 commits pushed to the master branch:

• a17fce7: 6445283: ProgressMonitorInputStream not large file aware (>2GB)
• 1ed03d8: 8292226: Prepare make for better Link Time Optimization support
• 79597f1: 8272702: Resolving URI relative path with no / may lead to incorrect toString
• 7b5f9ed: 8288966: Better handle very spiky promotion in G1
• 07c7977: 8290249: Vectorize signum on AArch64
• a3ec0bb: 8253413: [REDO] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
• 27b0f77: 8292318: Memory corruption in remove_dumptime_info
• 9a65524: 8290300: Use standard String-joining tools where applicable
• f9004fe: 8292561: Make "ReplayCompiles" a diagnostic product switch
• 2fbb936: 8292691: Move CompilerConfig::is_xxx() inline functions out of compilerDefinitions.hpp
• ... and 15 more: https://git.openjdk.org/jdk/compare/f2f0cd86bf4dce4633f484476077fd090549780e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 476c484.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.