JDK-8292669: IGV: Search not useable when in Overflow Toolbar

[tobiasholenstein]

Overview

The toolbar of the EditorTopComponent uses an overflow toolbar when it does not fit in the width of the TopComponent. When the window was not wide enough the QuickSearch used to land in the overflow toolbar. Unfortunately, QuickSearch stops working in the overflow toolbar.

Now the QuickSearch never lands in the overflow toolbar anymore as shown bellow:

Since the Netbeans Platform only allows for one occurrence of QuickSearch, it is only shown in the EditorTopComponent that was selected last.

Implementation

We introduce a new JPanel named topPanel as a parent container.

topPanel contains another JPanel toolbarPanel and a Toolbar quickSearchToolbar:

toolbarPanel uses the GridLayout which gives the original Toolbar toolBar the maximal available width while still allowing it to overflow.
On the right we have quickSearchToolbar, a Toolbar with a single element quickSearchPresenter. We give quickSearchPresenter a minimum size and use the BoxLayout in quickSearchToolbar that respects the minimum size of its children. Therefore the quickSearchToolbar never overflows.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8292669: IGV: Search not useable when in Overflow Toolbar

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer) ⚠️ Review applies to 11f02ffe
• Roberto Castañeda Lozano (@robcasloz - Reviewer)

Contributors

• Christian Hagedorn <chagedorn@openjdk.org>
• Tobias Holenstein <tholenstein@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9940/head:pull/9940
$ git checkout pull/9940

Update a local copy of the PR:
$ git checkout pull/9940
$ git pull https://git.openjdk.org/jdk pull/9940/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9940

View PR using the GUI difftool:
$ git pr show -t 9940

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9940.diff

[bridgekeeper]

👋 Welcome back tholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tobiasholenstein The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[tobiasholenstein]

/contributor add @chhagedorn

[openjdk]

@tobiasholenstein
Contributor Christian Hagedorn <chagedorn@openjdk.org> successfully added.

[mlbridge]

Webrevs

• 05: Full - Incremental (9312db3a)
• 04: Full - Incremental (17201d20)
• 03: Full - Incremental (0cac9614)
• 02: Full - Incremental (11f02ffe)
• 01: Full - Incremental (78864bc5)
• 00: Full (6cd754a3)

[tobiasholenstein]

/contributor add @tobiasholenstein

[openjdk]

@tobiasholenstein
Contributor Tobias Holenstein <tholenstein@openjdk.org> successfully added.

[chhagedorn]

Looks good, thanks for fixing this! Now I can better use IGV side by side with the code in the IDE.

I've tested it successfully on Linux.

[openjdk]

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292669: IGV: Search not useable when in Overflow Toolbar

Co-authored-by: Christian Hagedorn <chagedorn@openjdk.org>
Co-authored-by: Tobias Holenstein <tholenstein@openjdk.org>
Reviewed-by: chagedorn, rcastanedalo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 172 new commits pushed to the master branch:

• f91943c: 8292868: Explicitly pass a third temp register to MacroAssembler::store_heap_oop for aarch64
• 6354a57: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
• 3e18773: 8292880: Improve debuggee logging for com/sun/jdi/ClassUnloadEventTest.java
• 909e1ed: 8292919: Build failure due to UseJVMCICompiler was not declared when C2 is disabled after JDK-8292691
• 55f5a83: 8282410: Remove SA ProcDebugger support
• d83faea: 8292250: Create test for co-located JDI MethodEntry, Step, and Breakpoint events
• e353b57: 8292890: Remove PrintTouchedMethodsAtExit and LogTouchedMethods
• 95a33fe: 8292314: Cleanup legacy address handling
• 5d799d8: 8292304: [REDO] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS
• 4f50316: 8292680: Convert Dictionary to ConcurrentHashTable
• ... and 162 more: https://git.openjdk.org/jdk/compare/1c0f0f4211cf564c46753d2cb187c1ef485751cd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk-notifier]

@tobiasholenstein Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[tobiasholenstein]

Updated PR to add the Search when opening a new Tab without first clicking on it

[robcasloz]

The changeset works fine on Windows as well. I just have a style comment: in my opinion, the import ordering should be left as-is (alphabetic order) for consistency with the rest of the IGV project.

[tobiasholenstein]

The changeset works fine on Windows as well. I just have a style comment: in my opinion, the import ordering should be left as-is (alphabetic order) for consistency with the rest of the IGV project.

Thanks for testing on Windows Roberto!

You are right imports should stay in alphabetic order. I had to configure my IDE to not separate the java.* and javax.* imports. I changed it now

[tobiasholenstein]

Thanks @chhagedorn and @robcasloz for the reviews!

/integrate

[openjdk]

Going to push as commit 2b80349.
Since your change was applied there have been 174 commits pushed to the master branch:

• 4732abf: 8292910: Remove root to oop cast in HeapDumper
• f694f8a: 8292083: Detected container memory limit may exceed physical machine memory
• f91943c: 8292868: Explicitly pass a third temp register to MacroAssembler::store_heap_oop for aarch64
• 6354a57: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize
• 3e18773: 8292880: Improve debuggee logging for com/sun/jdi/ClassUnloadEventTest.java
• 909e1ed: 8292919: Build failure due to UseJVMCICompiler was not declared when C2 is disabled after JDK-8292691
• 55f5a83: 8282410: Remove SA ProcDebugger support
• d83faea: 8292250: Create test for co-located JDI MethodEntry, Step, and Breakpoint events
• e353b57: 8292890: Remove PrintTouchedMethodsAtExit and LogTouchedMethods
• 95a33fe: 8292314: Cleanup legacy address handling
• ... and 164 more: https://git.openjdk.org/jdk/compare/1c0f0f4211cf564c46753d2cb187c1ef485751cd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tobiasholenstein Pushed as commit 2b80349.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.