Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292699: Improve printing of classes in native debugger #9957

Closed

Conversation

iklam
Copy link
Member

@iklam iklam commented Aug 21, 2022

Current in gdb, you can print information about a class or method with something like

call ((InstanceKlass*)0x00000008000411b8)->print_on(tty)
call ((Method*)0x00007fffb4000d08)->print_codes_on(tty)

However, it's difficult to find a class or method by its name and print out its contents.

This RFE adds 3 new functions in debug.cpp so you can easily find classes/methods and print out their contents. They all have a flags argument that controls the verbosity.

  • findclass(): class name only
  • findmethod(): class name and method name
  • findmethod2(): class name and method name/signature

I also cleaned up BytecodeTracer to remove unnecessary complexity.

Here are some examples:

(gdb) call findclass("java/lang/Object", 0)
[0] 0x00000008000411b8 java.lang.Object, loader data: 0x00007ffff0130d10 of 'bootstrap'

(gdb) call findclass("java/lang/Object", 1)
[0] 0x00000008000411b8 java.lang.Object, loader data: 0x00007ffff0130d10 of 'bootstrap'
0x00007fffb4000658 <init> : ()V
0x00007fffb40010f0 finalize : ()V
0x00007fffb4000f00 wait0 : (J)V
0x00007fffb40008e8 equals : (Ljava/lang/Object;)Z
0x00007fffb4000aa0 toString : ()Ljava/lang/String;
0x00007fffb40007f0 hashCode : ()I
0x00007fffb4000720 getClass : ()Ljava/lang/Class;
0x00007fffb40009a0 clone : ()Ljava/lang/Object;
0x00007fffb4000b50 notify : ()V
0x00007fffb4000c20 notifyAll : ()V
0x00007fffb4000e50 wait : (J)V
0x00007fffb4001028 wait : (JI)V
0x00007fffb4000d08 wait : ()V

(gdb) call findclass("*ClassLoader", 0)
[0] 0x000000080007de40 jdk.internal.loader.ClassLoaders$BootClassLoader, loader data: 0x00007ffff0130d10 of 'bootstrap'
[1] 0x0000000800053c58 jdk.internal.loader.ClassLoaders$PlatformClassLoader, loader data: 0x00007ffff0130d10 of 'bootstrap'
[2] 0x0000000800053918 jdk.internal.loader.ClassLoaders$AppClassLoader, loader data: 0x00007ffff0130d10 of 'bootstrap'
[....]

(gdb) call findmethod2("*ang/Object*", "wait", "()V", 0x7)
[0] 0x00000008000411b8 java.lang.Object, loader data: 0x00007ffff0130d10 of 'bootstrap'
0x00007fffb4000d08 wait : ()V
0x00007fffb4000ce8 0 fast_aload_0
0x00007fffb4000ce9 1 lconst_0
0x00007fffb4000cea 2 invokevirtual 38 <java/lang/Object.wait(J)V>
0x00007fffb4000ced 5 return

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8292699: Improve printing of classes in native debugger

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9957/head:pull/9957
$ git checkout pull/9957

Update a local copy of the PR:
$ git checkout pull/9957
$ git pull https://git.openjdk.org/jdk pull/9957/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9957

View PR using the GUI difftool:
$ git pr show -t 9957

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9957.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2022

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 21, 2022

@iklam The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 21, 2022
@iklam iklam marked this pull request as ready for review August 21, 2022 07:12
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 21, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2022

@firefish985
Copy link

firefish985 commented Aug 21, 2022

very good

@iklam
Copy link
Member Author

iklam commented Aug 21, 2022

I added the ability to print out details for invokedynamic bytecodes.

0x00007fffb4500708 main : ([Ljava/lang/String;)V
0x00007fffb45006b8    0 invokedynamic bsm=104 7 <run()Ljava/lang/Runnable;>
  BSM: REF_invokeStatic 105 <java/lang/invoke/LambdaMetafactory.metafactory(Ljava/lang/invoke/MethodHandles$Lookup;Ljava/lang/String;Ljava/lang/invoke/MethodType;Ljava/lang/invoke/MethodType;Ljava/lang/invoke/MethodHandle;Ljava/lang/invoke/MethodType;)Ljava/lang/invoke/CallSite;> 
  arguments[3] = {
     <MethodType> 6 Symbol: '()V' count 65535
     <MethodHandle of kind 6 index at 113> 113 <HelloLambda.lambda$main$0()V> 
     <MethodType> 6 Symbol: '()V' count 65535
  }
  ConstantPoolCacheEntry:  19  (0x00007fffb4500f80)  [00|ba|    7]
                 [   0x00007fffb4427268]
                 [   0x000000000000000b]
                 [   0xffffffff83400001]
                 -------------
  Method: java/lang/invoke/Invokers$Holder.linkToTargetMethod(Ljava/lang/Object;)Ljava/lang/Object;
  appendix: java.lang.invoke.BoundMethodHandle$Species_L 
{0x000000062da8ab68} - klass: 'java/lang/invoke/BoundMethodHandle$Species_L'
 - ---- fields (total size 5 words):
 - private 'customizationCount' 'B' @12  0
 - private volatile 'updateInProgress' 'Z' @13  false
 - private final 'type' 'Ljava/lang/invoke/MethodType;' @16  a 'java/lang/invoke/MethodType'{0x000000062da831f8} = ()Ljava/lang/Runnable; (c5b5063f)
 - final 'form' 'Ljava/lang/invoke/LambdaForm;' @20  a 'java/lang/invoke/LambdaForm'{0x000000062da8aa48} => a 'java/lang/invoke/MemberName'{0x000000062da8d948} = {method} {0x00007fffb4502278} 'invoke' '(Ljava/lang/Object;)Ljava/lang/Object;' in 'java/lang/invoke/LambdaForm$MH+0x0000000800000400' (c5b51549)
 - private 'asTypeCache' 'Ljava/lang/invoke/MethodHandle;' @24  NULL (0)
 - private 'asTypeSoftCache' 'Ljava/lang/ref/SoftReference;' @28  NULL (0)
 - final 'argL0' 'Ljava/lang/Object;' @32  a 'HelloLambda$$Lambda$2+0x0000000800000a18'{0x000000062da86120} (c5b50c24)
0x00007fffb45006bd    5 invokestatic 11 <HelloLambda.doit(Ljava/lang/Runnable;)V> 

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ioi,

this looks neat. Not a full review, just some remarks:

  • Not your patch, but while playing with this I found that "call help()" needs a RM, which means gdb crashes out in a non-attached thread (e.g. the primordial one). Would be nice if no RM were needed.

  • Calling "findclass" from a java thread yielded this:

(gdb) call findclass("*", 7)
[Thread 0x7fffb28cf700 (LWP 112211) exited]

"Executing findclass"

Thread 2 "java" received signal SIGSEGV, Segmentation fault.
0x00007ffff6fe17ba in assert_locked_or_safepoint (lock=0x7ffff0027320) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/runtime/mutexLocker.cpp:178
178       fatal("must own lock %s", lock->name());
The program being debugged was signaled while in a function called from GDB.
GDB remains in the frame where the signal was received.
To change this behavior use "set unwindonsignal on".
Evaluation of the expression containing the function
(findclass(char const*, int)) will be abandoned.
When the function is done executing, GDB will silently stop.
(gdb) bt
#0  0x00007ffff6fe17ba in assert_locked_or_safepoint (lock=0x7ffff0027320) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/runtime/mutexLocker.cpp:178
#1  assert_locked_or_safepoint (lock=0x7ffff0027320) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/runtime/mutexLocker.cpp:172
#2  0x00007ffff639dcfb in ClassLoaderDataGraphIteratorBase<true>::ClassLoaderDataGraphIteratorBase (this=0x7ffff57b3390) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/runtime/handles.hpp:263
#3  ClassLoaderDataGraph::classes_do (klass_closure=klass_closure@entry=0x7ffff57b3420) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/classfile/classLoaderDataGraph.cpp:366
#4  0x00007ffff63acbe0 in ClassPrinter::print_classes_unlocked (class_name_pattern=class_name_pattern@entry=0x7ffff7d5de80 "*", flags=flags@entry=7) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/classfile/classPrinter.cpp:139
#5  0x00007ffff64ebda9 in findclass (class_name_pattern=0x7ffff7d5de80 "*", flags=7) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/utilities/debug.cpp:647
#6  <function called from gdb>
#7  __GI___libc_read (nbytes=8192, buf=0x7ffff57b3600, fd=0) at ../sysdeps/unix/sysv/linux/read.c:26
#8  __GI___libc_read (fd=fd@entry=0, buf=buf@entry=0x7ffff57b3600, nbytes=nbytes@entry=8192) at ../sysdeps/unix/sysv/linux/read.c:24
#9  0x00007ffff5682038 in read (__nbytes=8192, __buf=0x7ffff57b3600, __fd=0) at /usr/include/x86_64-linux-gnu/bits/unistd.h:44
#10 handleRead (fd=fd@entry=0, buf=buf@entry=0x7ffff57b3600, len=len@entry=8192) at /shared/projects/openjdk/jdk-jdk/source/src/java.base/unix/native/libjava/io_util_md.c:188
#11 0x00007ffff568178c in readBytes (env=0x7ffff0029170, this=<optimized out>, bytes=0x7ffff57b56e8, off=0, len=8192, fid=<optimized out>) at /shared/projects/openjdk/jdk-jdk/source/src/java.base/share/native/libjava/io_util.c:109
#12 0x00007fffe01eaf50 in ?? ()
#13 0x0000000000000040 in ?? ()
#14 0x00007ffff0028e50 in ?? ()
#15 0x00007fffa802f620 in ?? ()
  • You could add a simple test at least as gtests, looking for some well-known classes.

  • instead of using int for flags, maybe use an enum class and define the bitwise combine operator? Like this:

  enum class Mode : int {
    PRINT_METHOD_NAME       = 1 << 0,
    PRINT_BYTECODE          = 1 << 1,
    PRINT_BYTECODE_ADDR     = 1 << 2,
    PRINT_DYNAMIC           = 1 << 3, // extra information for invokedynamic (and dynamic constant ...)
  };
  
  constexpr enum Mode operator | (enum Mode selfValue, enum Mode inValue) { return (Mode)(uint32_t(selfValue) | uint32_t(inValue)); }

Cheers, Thomas

PRINT_DYNAMIC = 1 << 3, // extra information for invokedynamic (and dynamic constant ...)
};

// flags must be OR'ed from ClassPrinter::Mode for the next 3 functions
Copy link
Member

@tstuefe tstuefe Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give us a mode PRINT_ALL that or'es all of them modes together, and make that maybe the default for flags?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gdb doesn't support default parameters (I think the info for default params is not available in the debug info), so you need to pass in flags explicitly. If you pass 0 for findclass, it prints only the class names. If you pass 0 for findmethod and findmethods, they print only the class names and method names.

Printing everything by default may be too overwhelming.

BTW, I think findmethod vs findmethods may not be the right names. The former takes only method name, while the latter also takes a signature. Maybe I should rename the latter to findmethodex?

@iklam
Copy link
Member Author

iklam commented Aug 22, 2022

Hi Ioi,

this looks neat. Not a full review, just some remarks:

  • Not your patch, but while playing with this I found that "call help()" needs a RM, which means gdb crashes out in a non-attached thread (e.g. the primordial one). Would be nice if no RM were needed.

I think that would be too hard to do, as a lot of the printing functions depend on RM.

  • Calling "findclass" from a java thread yielded this:
(gdb) call findclass("*", 7)
[Thread 0x7fffb28cf700 (LWP 112211) exited]

"Executing findclass"

Thread 2 "java" received signal SIGSEGV, Segmentation fault.
0x00007ffff6fe17ba in assert_locked_or_safepoint (lock=0x7ffff0027320) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/runtime/mutexLocker.cpp:178
178       fatal("must own lock %s", lock->name());
...
(gdb) bt
#0  0x00007ffff6fe17ba in assert_locked_or_safepoint (lock=0x7ffff0027320) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/runtime/mutexLocker.cpp:178
#1  assert_locked_or_safepoint (lock=0x7ffff0027320) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/runtime/mutexLocker.cpp:172
#2  0x00007ffff639dcfb in ClassLoaderDataGraphIteratorBase<true>::ClassLoaderDataGraphIteratorBase (this=0x7ffff57b3390) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/runtime/handles.hpp:263
#3  ClassLoaderDataGraph::classes_do (klass_closure=klass_closure@entry=0x7ffff57b3420) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/classfile/classLoaderDataGraph.cpp:366
#4  0x00007ffff63acbe0 in ClassPrinter::print_classes_unlocked (class_name_pattern=class_name_pattern@entry=0x7ffff7d5de80 "*", flags=flags@entry=7) at /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/classfile/classPrinter.cpp:139

I changed ClassPrinter to use proper locking. The down side is if you call it in some narrow windows where the locks are already held, gdb would deadlock, but I think those windows are very small.

  • You could add a simple test at least as gtests, looking for some well-known classes.

I'll work on a few gtest cases.

  • instead of using int for flags, maybe use an enum class and define the bitwise combine operator? Like this:
  enum class Mode : int {
    PRINT_METHOD_NAME       = 1 << 0,
    PRINT_BYTECODE          = 1 << 1,
    PRINT_BYTECODE_ADDR     = 1 << 2,
    PRINT_DYNAMIC           = 1 << 3, // extra information for invokedynamic (and dynamic constant ...)
  };
  
  constexpr enum Mode operator | (enum Mode selfValue, enum Mode inValue) { return (Mode)(uint32_t(selfValue) | uint32_t(inValue)); }

The problem with 'enum class' is you can't use it easily inside gdb. You must do a lot of typing like:

call findclass("*Object", ClassPrinter::Mode::PRINT_ALL)
call findclass("*Object", ClassPrinter::Mode::PRINT_METHOD_NAME | ClassPrinter::Mode::PRINT_METHOD_ADDR)

In contrast, it's much easier to do this to enable everything.

call findclass("*Object", 0xff)

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to understand the need for new code for this but I have a couple of initial comments.

appendix->print_on(st);
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 444-461 should call a function in cpCache like:
void ConstantPoolCacheEntry::print(outputStream* st, int index) const {

If this doesn't have the format you want, you can enhance this function.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this code to ConstantPoolCacheEntry::print in version e4afb9f

} else {
// TODO: print info for tag.is_dynamic_constant()
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a function in ConstantPool::print()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block of code works on an indy_index, which is stored only inside the bytecode stream (it's the rewritten index of the invokedynamic bytecode. indy_index is not store anywhere inside the ConstantPool, so I can't find a good place to print this info in the printing functions of ConstantPool.

Note that you can have multiple invokedynamic bytecodes that use the same JVM_CONSTANT_InvokeDynamic entry in a ConstantPool, resulting in a different indy_index for each call site. Therefore, this per-callsite information cannot be printed as part of the JVM_CONSTANT_InvokeDynamic entry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2022

@iklam This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@matias9927
Copy link
Contributor

Overall, this looks good to me! I just have two comments:

  1. findmethod2() could use a better name, maybe something along the lines of find_method_and_signature()? Not sure if these method calls need to be in camel case or snake case as well.
  2. I noticed the use of continue statements in classFilePrinter: that code could probably be refactored into something that avoids the use of continue

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. I had a few comments, not many.

return;
}

void BytecodeTracer::trace_interpreter(const methodHandle& method, address bcp, uintptr_t tos, uintptr_t tos2, outputStream* st) {
if (TraceBytecodes && BytecodeCounter::counter_value() >= TraceBytecodesAt) {
ttyLocker ttyl; // 5065316: keep the following output coherent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should file a a RFE to make this a leaf mutex rather than ttyLocker (which does get broken to allow safepoints!) with no_safepoint_check assuming that the printing doesn't safepoint. Good to remove the no-longer accurate comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment also says:

    // Using the ttyLocker prevents the system from coming to
    // a safepoint within this code, which is sensitive to Method*
    // movement.

So are we trying to "prevent Method movement"? Does this even make sense after we switched to Permgen?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope doesn't make sense.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed https://bugs.openjdk.org/browse/JDK-8295851 "Do not use ttyLock in BytecodeTracer::trace"

method_signature_pattern, flags, tty);
}

extern "C" JNIEXPORT void printclass(intptr_t k, int flags) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that the function to print the method is findmethod, and the one to print the class is printclass. I see that findmethod is consistent with the 'find' functions above. Maybe this should be findclass() too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had two groups of printing functions with the following intention:

  • findclass/findmethod will search for class/methods by their names. Call these when you don't have an InstanceKlass* or Method*
  • printclass/printmethod should be used when you already have an InstanceKlass* or Method*

However, I realized that the second group of methods should really be something like InstanceKlass::print_xxx() and Method::print_xxx(), so you can do something like this in gdb

call ik->print_all_methods_with_bytecodes();

I have removed the second group of functions from this PR (commit 6675901). I may add them in a follow-up PR if necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. If you already have the InstanceKlass, it should be a function using that as a 'this' pointer.

@openjdk
Copy link

openjdk bot commented Oct 21, 2022

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292699: Improve printing of classes in native debugger

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 21, 2022
@iklam
Copy link
Member Author

iklam commented Oct 23, 2022

Overall, this looks good to me! I just have two comments:

  1. findmethod2() could use a better name, maybe something along the lines of find_method_and_signature()? Not sure if these method calls need to be in camel case or snake case as well.
  2. I noticed the use of continue statements in classFilePrinter: that code could probably be refactored into something that avoids the use of continue

I merged findmethod() and findmethod2() into a single function, so you can optionally specify the signature (which is not very common)

//   call findmethod("*ang/Object*", "wait", 0xff)       -> detailed disasm of all "wait" methods in j.l.Object
//   call findmethod("*ang/Object*", "wait:(*J*)V", 0x1) -> list all "wait" methods in j.l.Object that have a long parameter

The functions in debug.cpp are supposed to have short names so they can be easily typed in the debugger. E.g., we have pp, pns and pns2.

I refactored the code to avoid using the "continue" keyword. I think it's easier to read now. Thanks for the suggestion!

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the gtest.

} else {
// TODO: print info for tag.is_dynamic_constant()
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@@ -143,6 +144,15 @@ int Symbol::index_of_at(int i, const char* substr, int substr_len) const {
return -1;
}

bool Symbol::is_star_match(const char* star_pattern) const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this variable name should be "pattern" not "star_pattern" since it may not have a star.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@iklam
Copy link
Member Author

iklam commented Oct 24, 2022

Thanks @coleenp and @matias9927 for the review and @tstuefe for the suggestions.
/integrate

@openjdk
Copy link

openjdk bot commented Oct 24, 2022

Going to push as commit 89dafc0.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 7520d0a: 8295855: ProblemList jdk/jshell/CommandCompletionTest.java on linux-all
  • 1d15e5c: 8295716: Minimize disabled warnings in security libs
  • 8c86e92: 8295847: slow debug build error after JDK-8294466
  • e122321: 8295844: jdk/test/whitebox/CPUInfoTest.java failed with "not all features are known: expected true, was false"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2022
@openjdk openjdk bot closed this Oct 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2022
@openjdk
Copy link

openjdk bot commented Oct 24, 2022

@iklam Pushed as commit 89dafc0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
5 participants